Add component registry source resolution support to Terraform Stacks#37888
Merged
jpogran-hashi merged 8 commits intomainfrom Dec 10, 2025
Merged
Add component registry source resolution support to Terraform Stacks#37888jpogran-hashi merged 8 commits intomainfrom
jpogran-hashi merged 8 commits intomainfrom
Conversation
mjyocca
added
1.14-backport
mjyocca
force-pushed
the
jpogran/add_registry_component_source_support
branch
from
d93fbe2 to
2c4787c
Compare
Collaborator
|
We'd like to target 1.14. Should we apply the backport label or change the target branch? |
mjyocca
added
the
1.14-backport
Contributor
Backported dependency changeThis PR makes changes to dependencies in go.mod file(s) and is labelled for backport. Notice to the maintainer: Before merging the backport of this PR please follow our security scanning processes. |
jpogran-hashi
force-pushed
the
jpogran/add_registry_component_source_support
branch
from
10b50f0 to
85a9cb4
Compare
jar-b
approved these changes
Dec 5, 2025
Member
jar-b
left a comment
jar-b
left a comment
There was a problem hiding this comment.
LGTM 🎉
% TF_ACC=1 go test -count=1 ./...
go: downloading github.com/hashicorp/go-slug v0.18.1
ok github.com/hashicorp/terraform/internal/backend/remote-state/s3 209.243s
BBBmau
approved these changes
Dec 5, 2025
There was a problem hiding this comment.
LGTM on gcs side!
mau …/backend/remote-state/gcs jpogran/add_registry_component_source_support v1.25.0 14:17 TF_ACC=1 go test -count=1 ./...
go: downloading cloud.google.com/go/kms v1.15.5
ok github.com/hashicorp/terraform/internal/backend/remote-state/gcs 79.204s
This change implements the missing component source resolution case in the stack configuration loader, enabling Terraform Stacks to properly handle component registry sources from HCP Terraform and other component registries. The implementation mirrors the existing module registry resolution workflow, where component sources are first resolved to their versioned form using the source bundle's component metadata, then converted to final source addresses that can be used to locate the actual component code. This completes the integration between the terraform-registry-address component parsing capabilities and the go-slug sourcebundle component resolution APIs.
jpogran-hashi
force-pushed
the
jpogran/add_registry_component_source_support
branch
from
85a9cb4 to
ddc1d11
Compare
dsa0x
approved these changes
Dec 10, 2025
jpogran-hashi
deleted the
jpogran/add_registry_component_source_support
branch
Merged
3 tasks
dsa0x
pushed a commit
that referenced
this pull request
Dec 10, 2025
…37888) * Add component registry source resolution support to Terraform Stacks This change implements the missing component source resolution case in the stack configuration loader, enabling Terraform Stacks to properly handle component registry sources from HCP Terraform and other component registries. The implementation mirrors the existing module registry resolution workflow, where component sources are first resolved to their versioned form using the source bundle's component metadata, then converted to final source addresses that can be used to locate the actual component code. This completes the integration between the terraform-registry-address component parsing capabilities and the go-slug sourcebundle component resolution APIs. * chore: bump go-slug to v0.18.1 * fix: add case for component final source type * chore: rm space * chore: sync module deps * chore: update testdata with separate bundle * fix: manifest file json obj with trailing comma * Add changelog entry to 1.14 --------- Co-authored-by: Michael Yocca <michael.yocca@hashicorp.com>
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements the missing component source resolution case in the stack configuration loader, enabling Terraform Stacks to properly handle component registry sources from HCP Terraform and other component registries.
The implementation mirrors the existing module registry resolution workflow, where component sources are first resolved to their versioned form using the source bundle's component metadata, then converted to final source addresses that can be used to locate the actual component code. This completes the integration between the terraform-registry-address component parsing capabilities and the go-slug sourcebundle component resolution APIs.
Fixes #
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry