actions: connect resource instance nodes to after actions

[DanielMSchmidt]

Fixes #37930

Target Release

1.15.x

Rollback Plan

• If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

• This change is user-facing and I added a changelog entry.
• This change is not user-facing.

[jbardin]

Normally if something connects to a resource, it can connect to both the expand node and the instance nodes, and there is no need to differentiate between the two.

[mildwonkey]

This isn't a direct request, you don't need to make this change now, but I was curious about this section when I first saw it: Given that these variables only change from default if we're in apply mode(in the graph builder code); are they even necessary in this struct? Can we set these as helper variables directly in the Transformer based on the operation (t.operation)?

[DanielMSchmidt]

Okay, yeah I can connect both, no problem

[mildwonkey]

The graph edges look correct now! I think James had good feedback; we can connect to both the resource and resource instances, but otherwise this looks good!

[DanielMSchmidt]

Verified that it fixes the issue at hand

[mildwonkey]

nice, I see the new edges in the graph (this is the graph just before the pruning transformers run; the "redundant" edges don't show up in the final graph):

2025-11-24T12:46:12.953-0500 [TRACE] (graphTransformerMulti) Completed graph transform *terraform.ProviderTransformer with new graph:
  action.local_command.bar (expand) - *terraform.nodeExpandActionDeclaration
    provider["registry.terraform.io/hashicorp/local"] - *terraform.NodeApplyableProvider
  action.local_command.bar triggered by local_file.foo (apply - after) - *terraform.nodeActionTriggerApplyExpand
    local_file.foo - *terraform.NodeApplyableResourceInstance
    local_file.foo (expand) - *terraform.nodeExpandApplyableResource
    provider["registry.terraform.io/hashicorp/local"] - *terraform.NodeApplyableProvider
  local_file.foo - *terraform.NodeApplyableResourceInstance
    local_file.foo (expand) - *terraform.nodeExpandApplyableResource
    provider["registry.terraform.io/hashicorp/local"] - *terraform.NodeApplyableProvider
  local_file.foo (expand) - *terraform.nodeExpandApplyableResource
    provider["registry.terraform.io/hashicorp/local"] - *terraform.NodeApplyableProvider
  provider["registry.terraform.io/hashicorp/local"] - *terraform.NodeApplyableProvider

A bunch of transformers run (rather quietly) after this graph, and we end up with the same graph I posted from the first version 👍🏻

[mildwonkey]

lgtm, and extra thanks for reducing the scope on those variables!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.