stacks: Add local values walk to walk_dynamic

[DanielMSchmidt]

This helps us surface issues where we can only notice problems with local values in the stacks component language during the evaluation of the value.

Co-authored-by: Mutahhir Hayat mutahhir.hayat@hashicorp.com
Co-authored-by: Matej Risek matej.risek@hashicorp.com

Fixes #

Target Release

1.15.x

Rollback Plan

• If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

• This change is user-facing and I added a changelog entry.
• This change is not user-facing.

[nfagerlund]

Omg awesome, I was hoping you'd be able to track down a way to interrupt this.

I went ahead and re-ran my reproduction case, and sure enough, the plan errored and spewed the same list of errors I saw from the modules runtime into the diagnostics. I was unable to proceed to an apply and corrupt the state.

The empty state thing still definitely deserves love, but this definitely fixes the one cause of it that we've been able to observe.

[DanielMSchmidt]

@nfagerlund I'll also look into the state issue and in inputs being unknown to make sure no other way can lead to a similar issue

[DanielMSchmidt]

@nfagerlund This PR should fix the state issues: #37981

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.