Skip to content

Update iframe to VideoEmbed #36943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

Update iframe to VideoEmbed #36943

merged 1 commit into from
Apr 29, 2025

Conversation

im2nguyen
Copy link
Contributor

@im2nguyen im2nguyen commented Apr 29, 2025 •
edited by rkoron007
Loading

This updates the existing iframe for youtube to a VideoEmbed component. This is so we can standardize how we are serving and tracking video plays across DevDot.

Related PR: hashicorp/dev-portal#2699

Fixes #

Target Release

1.13.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@im2nguyen im2nguyen requested review from a team as code owners April 29, 2025 15:46
@im2nguyen im2nguyen added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Apr 29, 2025
SarahFrench
SarahFrench approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in the preview deployment to Vercel :shipit:

@im2nguyen im2nguyen added documentation 0.14-backport 1.0-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.1-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.2-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.3-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.4-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.5-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.6-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.7-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.8-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.9-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.11-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.12-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged labels Apr 29, 2025
rkoron007
rkoron007 approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@rkoron007 rkoron007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@im2nguyen im2nguyen merged commit 1ba125b into main Apr 29, 2025
32 of 49 checks passed
@im2nguyen im2nguyen deleted the iframe-to-videoembed branch April 29, 2025 19:30
This was referenced Apr 29, 2025
Closed
Closed
Closed
Merged
This was referenced Apr 29, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions GitHub Actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SarahFrench SarahFrench SarahFrench approved these changes

@rkoron007 rkoron007 rkoron007 approved these changes

Assignees
No one assigned
Labels
1.0-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.1-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.2-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.3-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.4-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.5-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.6-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.7-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.8-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.9-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.11-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.12-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged documentation no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@im2nguyen @SarahFrench @rkoron007