Skip to content

Commit 0b17a0b

Browse files
authored
HVS: shadow cache for dynamic secret responses (#939)
Caches HVS dynamic secrets (values and TTL/expiration info) for each HCPVaultSecretsApp in a k8s secret in the operator's namespace, so that dynamic secrets aren't fetched/created from the HVS API before the renewalPercent of their TTL.
1 parent 93e3baa commit 0b17a0b

12 files changed

+964
-81
lines changed

api/v1beta1/hcpvaultsecretsapp_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,10 @@ type HVSSyncConfig struct {
4545
// HVSDynamicSyncConfig configures sync behavior for HVS dynamic secrets.
4646
type HVSDynamicSyncConfig struct {
4747
// RenewalPercent is the percent out of 100 of a dynamic secret's TTL when
48-
// new secrets are generated. Defaults to 67 percent minus jitter.
48+
// new secrets are generated. Defaults to 67 percent plus up to 10% jitter.
4949
// +kubebuilder:default=67
5050
// +kubebuilder:validation:Minimum=0
51-
// +kubebuilder:validation:Maximum=100
51+
// +kubebuilder:validation:Maximum=90
5252
RenewalPercent int `json:"renewalPercent,omitempty"`
5353
}
5454

chart/crds/secrets.hashicorp.com_hcpvaultsecretsapps.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,8 @@ spec:
253253
default: 67
254254
description: |-
255255
RenewalPercent is the percent out of 100 of a dynamic secret's TTL when
256-
new secrets are generated. Defaults to 67 percent minus jitter.
257-
maximum: 100
256+
new secrets are generated. Defaults to 67 percent plus up to 10% jitter.
257+
maximum: 90
258258
minimum: 0
259259
type: integer
260260
type: object

config/crd/bases/secrets.hashicorp.com_hcpvaultsecretsapps.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,8 @@ spec:
253253
default: 67
254254
description: |-
255255
RenewalPercent is the percent out of 100 of a dynamic secret's TTL when
256-
new secrets are generated. Defaults to 67 percent minus jitter.
257-
maximum: 100
256+
new secrets are generated. Defaults to 67 percent plus up to 10% jitter.
257+
maximum: 90
258258
minimum: 0
259259
type: integer
260260
type: object

0 commit comments

Comments
 (0)