Add some client_factory tests

Author: benashz

controllers/vaultdynamicsecret_controller_test.go

@@ -1039,6 +1039,17 @@ func TestVaultDynamicSecretReconciler_vaultClientCallback(t *testing.T) {
 				},
 			},
 		},
+		{
+			ObjectMeta: metav1.ObjectMeta{
+				Namespace: "other",
+				Name:      "canary-other-ns",
+			},
+			Status: secretsv1beta1.VaultDynamicSecretStatus{
+				VaultClientMeta: secretsv1beta1.VaultClientMeta{
+					CacheKey: "kubernetes-12345",
+				},
+			},
+		},
 	}
 
 	tests := []struct {

internal/vault/client_factory.go

@@ -120,6 +120,11 @@ func (m *cachingClientFactory) Stop() {
 	}
 }
 
+// RegisterClientCallbackHandler registers a ClientCallbackHandler with the
+// cachingClientFactory. The ClientCallbackHandler will be called when the
+// specified event occurs. There is no duplication detection, so the same handler
+// can be registered multiple times. The caller is responsible for ensuring that
+// there are no duplicates.
 func (m *cachingClientFactory) RegisterClientCallbackHandler(cb ClientCallbackHandler) {
 	m.mu.Lock()
 	defer m.mu.Unlock()

internal/vault/client_factory_test.go

@@ -0,0 +1,76 @@
+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: BUSL-1.1
+
+package vault
+
+import (
+	"context"
+	"sync"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func Test_cachingClientFactory_RegisterClientCallbackHandler(t *testing.T) {
+	cb1 := func(_ context.Context, _ Client, _ error) {
+		// do nothing
+	}
+	cb2 := func(_ context.Context, _ Client, _ error) {
+		// do nothing
+	}
+	cb3 := func(_ context.Context, _ Client, _ error) {
+		// do nothing
+	}
+	tests := []struct {
+		name    string
+		cbs     []ClientCallbackHandler
+		wantErr assert.ErrorAssertionFunc
+	}{
+		{
+			name: "single",
+			cbs: []ClientCallbackHandler{
+				{
+					On:       ClientCallbackOnLifetimeWatcherDone,
+					Callback: cb1,
+				},
+			},
+			wantErr: assert.NoError,
+		},
+		{
+			name: "multiple",
+			cbs: []ClientCallbackHandler{
+				{
+					On:       ClientCallbackOnLifetimeWatcherDone,
+					Callback: cb1,
+				},
+				{
+					On:       ClientCallbackOnLifetimeWatcherDone,
+					Callback: cb2,
+				},
+				{
+					On:       ClientCallbackOnLifetimeWatcherDone,
+					Callback: cb3,
+				},
+			},
+			wantErr: assert.NoError,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			m := &cachingClientFactory{}
+			require.Greater(t, len(tt.cbs), 0, "no test ClientCallbackHandlers provided")
+
+			wg := sync.WaitGroup{}
+			wg.Add(len(tt.cbs))
+			for _, cb := range tt.cbs {
+				go func(cb ClientCallbackHandler) {
+					defer wg.Done()
+					m.RegisterClientCallbackHandler(cb)
+				}(cb)
+			}
+			wg.Wait()
+			assert.Equal(t, len(tt.cbs), len(m.clientCallbacks))
+		})
+	}
+}