Fix go vet errors

benashz · benashz · commit 5a30b5fa4bea · 2025-09-04T18:04:55.000-04:00
diff --git a/controllers/vaultdynamicsecret_controller.go b/controllers/vaultdynamicsecret_controller.go
@@ -300,7 +300,8 @@ func (r *VaultDynamicSecretReconciler) Reconcile(ctx context.Context, req ctrl.R
 					consts.TypeLeaseRenewal,
 					consts.ReasonSecretLeaseRenewalError,
 					metav1.ConditionFalse,
-					err.Error()),
+					"Could not renew lease, err=%s",
+					err),
 			)
 		}
 	}
@@ -372,15 +373,18 @@ func (r *VaultDynamicSecretReconciler) Reconcile(ctx context.Context, req ctrl.R
 				newConditionNow(o,
 					consts.TypeRolloutRestart,
 					consts.ReasonRolloutRestartTriggeredFailed,
-					metav1.ConditionFalse, err.Error()),
+					metav1.ConditionFalse,
+					"Rollout restart trigger failed: %s",
+					err),
 			)
 		} else {
 			conditions = append(
 				conditions,
 				newConditionNow(o,
 					consts.TypeRolloutRestart,
 					consts.ReasonRolloutRestartTriggered,
-					metav1.ConditionTrue, "Rollout restart triggered"),
+					metav1.ConditionTrue,
+					"Rollout restart triggered"),
 			)
 		}
 	}
diff --git a/controllers/vaultstaticsecret_controller.go b/controllers/vaultstaticsecret_controller.go
@@ -273,7 +273,9 @@ func (r *VaultStaticSecretReconciler) Reconcile(ctx context.Context, req ctrl.Re
 				newConditionNow(o,
 					consts.TypeRolloutRestart,
 					consts.ReasonRolloutRestartTriggeredFailed,
-					metav1.ConditionFalse, err.Error()),
+					metav1.ConditionFalse,
+					"Rollout restart trigger failed, err=%s",
+					err),
 			)
 		} else {
 			conditions = append(

Original file line number	Diff line number	Diff line change
`@@ -300,7 +300,8 @@ func (r *VaultDynamicSecretReconciler) Reconcile(ctx context.Context, req ctrl.R`
`300`	`300`	`consts.TypeLeaseRenewal,`
`301`	`301`	`consts.ReasonSecretLeaseRenewalError,`
`302`	`302`	`metav1.ConditionFalse,`
`303`		`- err.Error()),`
	`303`	`+ "Could not renew lease, err=%s",`
	`304`	`+ err),`
`304`	`305`	`)`
`305`	`306`	`}`
`306`	`307`	`}`
`@@ -372,15 +373,18 @@ func (r *VaultDynamicSecretReconciler) Reconcile(ctx context.Context, req ctrl.R`
`372`	`373`	`newConditionNow(o,`
`373`	`374`	`consts.TypeRolloutRestart,`
`374`	`375`	`consts.ReasonRolloutRestartTriggeredFailed,`
`375`		`- metav1.ConditionFalse, err.Error()),`
	`376`	`+ metav1.ConditionFalse,`
	`377`	`+ "Rollout restart trigger failed: %s",`
	`378`	`+ err),`
`376`	`379`	`)`
`377`	`380`	`} else {`
`378`	`381`	`conditions = append(`
`379`	`382`	`conditions,`
`380`	`383`	`newConditionNow(o,`
`381`	`384`	`consts.TypeRolloutRestart,`
`382`	`385`	`consts.ReasonRolloutRestartTriggered,`
`383`		`- metav1.ConditionTrue, "Rollout restart triggered"),`
	`386`	`+ metav1.ConditionTrue,`
	`387`	`+ "Rollout restart triggered"),`
`384`	`388`	`)`
`385`	`389`	`}`
`386`	`390`	`}`