VSS: use a constant backoff client cache errors

Updates the VaultStaticSecretReconciler to use a constant backoff when
it encounters an error when getting a client from the factory. This is
the same approach taken in the VDS and VPS controllers.

Author: benashz

controllers/vaultstaticsecret_controller.go

@@ -76,7 +76,10 @@ func (r *VaultStaticSecretReconciler) Reconcile(ctx context.Context, req ctrl.Re
 	if err != nil {
 		r.Recorder.Eventf(o, corev1.EventTypeWarning, consts.ReasonVaultClientConfigError,
 			"Failed to get Vault auth login: %s", err)
-		return ctrl.Result{}, err
+		_, jitter := computeMaxJitterWithPercent(requeueDurationOnError, 0.5)
+		return ctrl.Result{
+			RequeueAfter: requeueDurationOnError + time.Duration(jitter),
+		}, nil
 	}
 
 	var requeueAfter time.Duration