Skip to content

Support containers version 0.8. #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #97 ...
jonathanknowles opened this issue Mar 4, 2025 · 5 comments
Open
Tracked by #97 ...

Support containers version 0.8. #319

jonathanknowles opened this issue Mar 4, 2025 · 5 comments

Comments

@jonathanknowles
Copy link

jonathanknowles commented Mar 4, 2025

Version 0.8 of the containers package has been released, but hashable currently has an upper bound of < 0.8:

hashable/hashable.cabal

Lines 86 to 89 in e29ed1a

build-depends:
, base >=4.18.0.0 && <4.22
, bytestring >=0.11.5.3 && <0.13
, containers >=0.6.7 && <0.8

I was able to successfully build and test with:

cabal test all \
    --constraint=containers==0.8 \
    --allow-newer=hashable:containers

Which indicates that solving this issue might just a require a bump of the upper bound for containers.

@ivanperez-keera
Copy link

ivanperez-keera commented Mar 8, 2025

Also running into this.

It's currently blocking: Copilot-Language/copilot#603

@ivanperez-keera
Copy link

Does this require changes to dependencies or the code, or can the upper bound just be bumped?

@jonathanknowles
Copy link
Author

jonathanknowles commented Mar 26, 2025

Does this require changes to dependencies or the code, or can the upper bound just be bumped?

@ivanperez-keera I think it just requires a bump to the upper bound.

I was able to successfully build and test this with:

cabal test all \
    --constraint=containers==0.8 \
    --allow-newer=hashable:containers

@ivanperez-keera
Copy link

@phadej Would you accept such a PR?

@phadej
Copy link
Contributor

phadej commented Mar 26, 2025

Most likely I won't bother with containers-0.8 support until GHC is shipping it. Or if when haskell/cabal#9669 is resolved in some satisfible way.

If you want sooner containers-0.8 support, help those matters instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants