Skip to content

Commit 0bedc4a

Browse files
Disable everfailing assertion (#8821)
* Disable everfailing assertion See discussion at #6006 * Fix unused parameter --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
1 parent 0ea1001 commit 0bedc4a

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

cabal-install/src/Distribution/Client/ProjectPlanning.hs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -235,19 +235,24 @@ sanityCheckElaboratedConfiguredPackage
235235
-> ElaboratedConfiguredPackage
236236
-> a
237237
-> a
238-
sanityCheckElaboratedConfiguredPackage sharedConfig
238+
sanityCheckElaboratedConfiguredPackage _sharedConfig
239239
elab@ElaboratedConfiguredPackage{..} =
240240
(case elabPkgOrComp of
241241
ElabPackage pkg -> sanityCheckElaboratedPackage elab pkg
242242
ElabComponent comp -> sanityCheckElaboratedComponent elab comp)
243243

244+
-- The assertion below fails occasionally for unknown reason
245+
-- so it was muted until we figure it out, otherwise it severely
246+
-- hinders our ability to share and test development builds of cabal-install.
247+
-- Tracking issue: https://github.com/haskell/cabal/issues/6006
248+
--
244249
-- either a package is being built inplace, or the
245250
-- 'installedPackageId' we assigned is consistent with
246251
-- the 'hashedInstalledPackageId' we would compute from
247252
-- the elaborated configured package
248-
. assert (elabBuildStyle == BuildInplaceOnly ||
249-
elabComponentId == hashedInstalledPackageId
250-
(packageHashInputs sharedConfig elab))
253+
-- . assert (elabBuildStyle == BuildInplaceOnly ||
254+
-- elabComponentId == hashedInstalledPackageId
255+
-- (packageHashInputs sharedConfig elab))
251256

252257
-- the stanzas explicitly disabled should not be available
253258
. assert (optStanzaSetNull $

0 commit comments

Comments
 (0)