@@ -117,17 +117,25 @@ jobs:
117
117
name : Validate old ghcs ${{ matrix.extra-ghc }}
118
118
runs-on : ubuntu-18.04
119
119
needs : validate
120
+ # This job needs an older ubuntu (16.04) cause the needed
121
+ # old ghcs using the `-dyn` flavour are not installable
122
+ # from ppa/hvr in newer ones
123
+ # see https://github.com/haskell/cabal/issues/8011
120
124
container :
121
125
image : phadej/ghc:8.8.4-xenial
122
126
123
127
strategy :
124
128
matrix :
129
+ # Newer ghc versions than 8.8.4 has to be installed with ghcup cause
130
+ # they are not available in ppa/hvr. The ghcup installation
131
+ # needs `sudo` which is not available in the xenial container
125
132
ghc : ["8.8.4"]
126
133
extra-ghc : ["7.10.3", "7.8.4", "7.6.3", "7.4.2", "7.2.2", "7.0.4"]
127
134
128
135
steps :
129
136
130
- # We can't use actions/checkout with the docker container, see:
137
+ # We can't use actions/checkout with the xenial docker container
138
+ # cause it does not work with the git version included in it, see:
131
139
# https://github.com/actions/checkout/issues/170
132
140
# https://github.com/actions/checkout/issues/295
133
141
# - uses: actions/checkout@v2
@@ -148,8 +156,9 @@ jobs:
148
156
with :
149
157
ghc-version : ${{ matrix.ghc }}
150
158
151
- # See the following link for a breakdown of the following step
152
- # https://github.com/haskell/actions/issues/7#issuecomment-745697160
159
+ # TODO: ideally those jobs should reuse the cabal artifact generated in the
160
+ # previous step. Until that we use the cache generated in the previous step
161
+ # to make the build faster. This job only needs it in read mode.
153
162
- uses : actions/cache@v2
154
163
with :
155
164
path : |
0 commit comments