Skip to content

Commit c91d6d3

Browse files
committed
Add comments about caveats and todos
1 parent 9b386cd commit c91d6d3

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

.github/workflows/linux.yml

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,17 +117,25 @@ jobs:
117117
name: Validate old ghcs ${{ matrix.extra-ghc }}
118118
runs-on: ubuntu-18.04
119119
needs: validate
120+
# This job needs an older ubuntu (16.04) cause the needed
121+
# old ghcs using the `-dyn` flavour are not installable
122+
# from ppa/hvr in newer ones
123+
# see https://github.com/haskell/cabal/issues/8011
120124
container:
121125
image: phadej/ghc:8.8.4-xenial
122126

123127
strategy:
124128
matrix:
129+
# Newer ghc versions than 8.8.4 has to be installed with ghcup cause
130+
# they are not available in ppa/hvr. The ghcup installation
131+
# needs `sudo` which is not available in the xenial container
125132
ghc: ["8.8.4"]
126133
extra-ghc: ["7.10.3", "7.8.4", "7.6.3", "7.4.2", "7.2.2", "7.0.4"]
127134

128135
steps:
129136

130-
# We can't use actions/checkout with the docker container, see:
137+
# We can't use actions/checkout with the xenial docker container
138+
# cause it does not work with the git version included in it, see:
131139
# https://github.com/actions/checkout/issues/170
132140
# https://github.com/actions/checkout/issues/295
133141
# - uses: actions/checkout@v2
@@ -148,8 +156,9 @@ jobs:
148156
with:
149157
ghc-version: ${{ matrix.ghc }}
150158

151-
# See the following link for a breakdown of the following step
152-
# https://github.com/haskell/actions/issues/7#issuecomment-745697160
159+
# TODO: ideally those jobs should reuse the cabal artifact generated in the
160+
# previous step. Until that we use the cache generated in the previous step
161+
# to make the build faster. This job only needs it in read mode.
153162
- uses: actions/cache@v2
154163
with:
155164
path: |

0 commit comments

Comments
 (0)