Skip to content

Package network-3.1.2.3 does not compile on Windows (autoconf problems) #7707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mikolaj opened this issue Oct 7, 2021 · 4 comments
Closed

Comments

@Mikolaj
Copy link
Member

Mikolaj commented Oct 7, 2021

Edit: @hasufell pointed out that our CI still uses cabal 3.4 and so what happens is that we are seeing first time in the wild that cabal 3.4. doesn't work with autoconf files generated with new autoconf version. Sadly, even our CI Windows dogfooding jobs first use 3.4 to build new cabal and only then test the new cabal, so their failure does not mean that 3.6.2 is broken (as I mistakenly assumed and panicked). See #7708.

.

Old outdated text follows:

So far spotted on 3.6. branch:

https://github.com/haskell/cabal/pull/7706/checks?check_run_id=3825123562

Is says configure: error: cannot find required auxiliary files: config.guess config.sub, but the files are present in the package and in the same location as in the previous network version.

We'd need to test cabal 3.4 and branch master to get a fuller picture. Also, it would be good to make sure network-3.1.2.2 compiles fine with 3.6 and master, in case the problem is some global GHA change.

Edit: @hasufell reports if fails on cabal 3.4 on Windows, as well, and 3.1.2.2 seems to work fine.

@Mikolaj Mikolaj changed the title Package network does not compile on Windows (autoconf problems) Package network-3.1.2.3 does not compile on Windows (autoconf problems) Oct 7, 2021
@Mikolaj
Copy link
Member Author

Mikolaj commented Oct 7, 2021

Edit: see the ticket description for a correction to these findings.

LIkely suspects:

haskell/network#510 [edit: this one changes the autoconf not-automatically-generated files to new ones, not even generated by network devs, but newer straight from upstream, but as @Mistuke corrected me, this should not matter; what matters is the version of autoconf used to produce the autogenerated files]

haskell/network#508 [edit: this one probably only masked the failure on network's CI]

Nothing else seems obviously related:

https://github.com/haskell/network/compare/v3.1.2.2..v3.1.2.3

@Mistuke
Copy link
Collaborator

Mistuke commented Oct 7, 2021

haskell/network#510 [edit: this one changes the autoconf generated files to new ones, not even generated by network devs, but newer straight from upstream --- no wonder we didn't test those when checking our workaround in cabal 3.6.2]

It's not, when a release is made the configure script is regenerated by the maintainer. The maintainer's local machine has autoconf 2.7+, which causes the new configure format to be generated.

So it's not the changes in the packages, it's the act of generating the release itself. That said the changes in 3.6.2 should work.

@Mikolaj
Copy link
Member Author

Mikolaj commented Oct 7, 2021

Yes, @hasufell confirmed 3.6.2 works with the changes, without regenerating the files.

@Mikolaj
Copy link
Member Author

Mikolaj commented Oct 8, 2021

This is now fixed upstream. Thank you all the firefighting team.

@Mikolaj Mikolaj closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants