Fix #2804: Text Platform roundtrip (with tests)#2862
Merged
23Skidoo merged 4 commits intohaskell:masterfrom Oct 12, 2015
Merged
Fix #2804: Text Platform roundtrip (with tests)#286223Skidoo merged 4 commits intohaskell:masterfrom
23Skidoo merged 4 commits intohaskell:masterfrom
Conversation
Member
|
LGTM. |
Collaborator
Author
|
Have to fix the ambiguous parse though.
otherwise:
|
Closed
Collaborator
Author
|
ping @23Skidoo, now this is green. AFAICS parse part of |
Member
There was a problem hiding this comment.
Looks like ident is now identical to dashlessIdent. Is this intentional?
Collaborator
Author
There was a problem hiding this comment.
My bad, ident should have dash. Will fix shortly.
Collaborator
Author
|
@23Skidoo does it look ok now? |
Member
|
It does! Merging, thanks! |
23Skidoo
added a commit
that referenced
this pull request
Oct 12, 2015
Fix #2804: Text Platform roundtrip (with tests)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.