Skip to content

Commit 8b7f047

Browse files
committed
Haskell CI: switch off testing for GHC 9.2 and below
Reason: haskell/cabal#8554 Cabal-3.8.1.0 does not work with ghc < 9.4 needed by doctest-parallel
1 parent 2caabc9 commit 8b7f047

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

.github/workflows/haskell-ci.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ jobs:
8585
echo "CABAL=$HOME/.ghcup/bin/cabal-3.6.2.0 -vnormal+nowrap" >> "$GITHUB_ENV"
8686
HCNUMVER=$(${HC} --numeric-version|perl -ne '/^(\d+)\.(\d+)\.(\d+)(\.(\d+))?$/; print(10000 * $1 + 100 * $2 + ($3 == 0 ? $5 != 1 : $3))')
8787
echo "HCNUMVER=$HCNUMVER" >> "$GITHUB_ENV"
88-
echo "ARG_TESTS=--enable-tests" >> "$GITHUB_ENV"
88+
if [ $((HCNUMVER >= 90400)) -ne 0 ] ; then echo "ARG_TESTS=--enable-tests" >> "$GITHUB_ENV" ; else echo "ARG_TESTS=--disable-tests" >> "$GITHUB_ENV" ; fi
8989
echo "ARG_BENCH=--enable-benchmarks" >> "$GITHUB_ENV"
9090
echo "HEADHACKAGE=false" >> "$GITHUB_ENV"
9191
echo "ARG_COMPILER=--$HCKIND --with-compiler=$HC" >> "$GITHUB_ENV"
@@ -167,9 +167,7 @@ jobs:
167167
echo " ghc-options: -Werror=missing-methods" >> cabal.project
168168
cat >> cabal.project <<EOF
169169
EOF
170-
cat >> cabal.project.local <<EOF
171-
constraints: ghc installed
172-
EOF
170+
$HCPKG list --simple-output --names-only | perl -ne 'for (split /\s+/) { print "constraints: $_ installed\n" unless /^(Cabal|hackage-server|parsec|text)$/; }' >> cabal.project.local
173171
cat cabal.project
174172
cat cabal.project.local
175173
- name: dump install plan
@@ -194,7 +192,7 @@ jobs:
194192
$CABAL v2-build $ARG_COMPILER $ARG_TESTS $ARG_BENCH all --write-ghc-environment-files=always
195193
- name: tests
196194
run: |
197-
$CABAL v2-test $ARG_COMPILER $ARG_TESTS $ARG_BENCH all --test-show-details=direct
195+
if [ $((HCNUMVER >= 90400)) -ne 0 ] ; then $CABAL v2-test $ARG_COMPILER $ARG_TESTS $ARG_BENCH all --test-show-details=direct ; fi
198196
- name: cabal check
199197
run: |
200198
cd ${PKGDIR_hackage_server} || false

cabal.haskell-ci

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11
branches: master ci*
22

3-
installed: -all +ghc
4-
-- installed: +all -Cabal -text -parsec
5-
6-
-- -- irc-channels works with GHA, but why send to a channel
7-
-- -- when one can subscribe to github notifications?
8-
-- irc-channels: irc.libera.chat#hackage
3+
installed: +all -Cabal -text -parsec
4+
-- Did not help to salvage ghc-9.2 and below:
5+
-- installed: -all +ghc
96

107
-- Does not work with GHA:
118
-- -- allow failures with ghc-7.6 and ghc-7.8
@@ -20,3 +17,8 @@ apt: libbrotli-dev
2017
-- even though we don't define any library.
2118
haddock-components: all
2219
-- since haskell-ci 0.15.20220822
20+
21+
tests: >= 9.4
22+
-- parallel-doctest uses the ghc package
23+
-- and thus does not build with Cabal-3.8.1.0 below GHC 9.4
24+
-- See: https://github.com/haskell/cabal/issues/8554

0 commit comments

Comments
 (0)