Don't use typecheck rule for non FOIs in refine imports plugin

Also add an assertion to check that we never use non-FOI rules

Fixes #2962

Author: wz1000

ghcide/src/Development/IDE/Core/Rules.hs

@@ -650,7 +650,11 @@ typeCheckRule :: Recorder (WithPriority Log) -> Rules ()
 typeCheckRule recorder = define (cmapWithPrio LogShake recorder) $ \TypeCheck file -> do
     pm <- use_ GetParsedModule file
     hsc  <- hscEnv <$> use_ GhcSessionDeps file
-    typeCheckRuleDefinition hsc pm
+    foi <- use_ IsFileOfInterest file
+    -- We should only call the typecheck rule for files of interest.
+    -- Keeping typechecked modules in memory for other files is
+    -- very expensive.
+    assert (foi /= NotFOI) $ typeCheckRuleDefinition hsc pm
 
 knownFilesRule :: Recorder (WithPriority Log) -> Rules ()
 knownFilesRule recorder = defineEarlyCutOffNoFile (cmapWithPrio LogShake recorder) $ \GetKnownTargets -> do

plugins/hls-refine-imports-plugin/src/Ide/Plugin/RefineImports.hs

@@ -187,8 +187,8 @@ refineImportsRule recorder = define (cmapWithPrio LogShake recorder) $ \RefineIm
       -- second layer is from the imports of first layer to their imports
       ImportMap importIm <- use_ GetImportMap path
       forM importIm $ \imp_path -> do
-        imp_tmr <- use_ TypeCheck imp_path
-        return $ tcg_exports $ tmrTypechecked imp_tmr
+        imp_hir <- use_ GetModIface imp_path
+        return $ mi_exports $ hirModIface imp_hir
 
   -- Use the GHC api to extract the "minimal" imports
   -- We shouldn't blindly refine imports