Skip to content

Files for golden test missing in hackage release of hls-tactics-plugin #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maralorn opened this issue Mar 9, 2021 · 1 comment · Fixed by #1605
Closed

Files for golden test missing in hackage release of hls-tactics-plugin #1536

maralorn opened this issue Mar 9, 2021 · 1 comment · Fixed by #1605
Assignees
@jneira
Labels
CI Continuous integration type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@maralorn
Copy link
Contributor

maralorn commented Mar 9, 2021 •
edited
Loading

When packaging hls-tactics-plugin in nixpkgs, I tried to run the tests to make sure it works fine.
The golden tests all fail because of missing golden files.

Steps to reproduce

Get hls-tactics-plugin from hackage and run the golden tests.

Expected behaviour

They pass.

Actual behaviour

They don‘t.

Include debug information

Release: 1.0.0.0
@jneira jneira added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. CI Continuous integration labels Mar 9, 2021
@jneira jneira self-assigned this Mar 22, 2021
@jneira jneira mentioned this issue Mar 22, 2021
Merged
@jneira
Copy link
Member

jneira commented Mar 22, 2021

pull request adding test data files: #1605

@mergify mergify bot closed this as completed in #1605 Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jneira jneira

Labels
CI Continuous integration type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test data files to extra-source-files jneira/haskell-language-server
2 participants
@jneira @maralorn