Config available to ghcide Main is always default

[isovector]

While working on a fix for #1873, I noticed that my plugin's configuration wasn't available when building the IdeOptions. But that's odd, because it's obviously getting pulled:

haskell-language-server/ghcide/src/Development/IDE/Main.hs

Line 220 in dee0216

config <- LSP.runLspT env LSP.getConfig

Tracing this, however, gives the following object:

Config {checkParents = CheckOnSaveAndClose, checkProject = True, hlintOn = True, diagnosticsOnChange = True, diagnosticsDebounceDuration = 350000, liquidOn = False, formatOnImportOn = True, formattingProvider = "ormolu", maxCompletions = 40, plugins = fromList []}

which correspond exactly with the Default instance:

haskell-language-server/hls-plugin-api/src/Ide/Plugin/Config.hs

Lines 63 to 78 in dee0216

	instance Default Config where
	def = Config
	{ checkParents = CheckOnSaveAndClose
	, checkProject = True
	, hlintOn = True
	, diagnosticsOnChange = True
	, diagnosticsDebounceDuration = 350000
	, liquidOn = False
	, formatOnImportOn = True
	-- , formattingProvider = "brittany"
	, formattingProvider = "ormolu"
	-- , formattingProvider = "floskell"
	-- , formattingProvider = "stylish-haskell"
	, maxCompletions = 40
	, plugins = Map.empty
	}

What's going on here? Do we expect the config to be initialized by this point?

[pepeiborra]

Is it possible that you are being bitten by the bug below?

haskell/lsp#337

[pepeiborra]

We looked further into this and the problem is that some editors, including VSCode, may refuse to include the config in the initialisation notification and instead only send it later via a WorkspaceDidChangeConfiguration notification. So we can never rely on the initialisation time config, and instead must always call Ide.PluginUtils.getClientConfig to retrieve the current config dynamically

[isovector]

Closing this, since it's a client-side problem.