Skip to content

hls-splice-plugin: can't compile with GHC 9.2.2 #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maerten opened this issue Mar 23, 2022 · 5 comments
Closed

hls-splice-plugin: can't compile with GHC 9.2.2 #2796

maerten opened this issue Mar 23, 2022 · 5 comments
Labels
component: hls-splice-plugin GHC issues with particular GHC versions

Comments

@maerten
Copy link

maerten commented Mar 23, 2022

Your environment

Which OS do you use:
MacOS

Which LSP client (editor/plugin) do you use:
Directly starting haskell-language-server from terminal while trying to install it properly.

Describe your project (alternative: link to the project):
haskell project using QuasiQuotes language extension

Steps to reproduce

Try compiling hls after enabling the hls-splice-plugin in stack-9.2.yaml

Expected behaviour

Not entirely expected, but desired behavior is that it just compiles without issue :)

Actual behaviour

Compilation error related to Language.Haskell.GHC.ExactPrint

Include debug information

hls-splice-plugin                 > [2 of 2] Compiling Ide.Plugin.Splice
hls-splice-plugin                 >
hls-splice-plugin                 > /private/var/folders/0c/zmpjp7l568xcvnt49pkkn5p00000gn/T/stack-c77dc10926bf43ba/hls-splice-plugin-1.0.1.0/src/Ide/Plugin/Splice.hs:55:51: error:
hls-splice-plugin                 >     Module
hls-splice-plugin                 >     ‘Language.Haskell.GHC.ExactPrint’
hls-splice-plugin                 >     does not export
hls-splice-plugin                 >     ‘setPrecedingLines’
hls-splice-plugin                 >    |
hls-splice-plugin                 > 55 | import           Language.Haskell.GHC.ExactPrint (setPrecedingLines,
hls-splice-plugin                 >    |                                                   ^^^^^^^^^^^^^^^^^

The README at https://github.com/alanz/ghc-exactprint shows there is a new (and perhaps backwards incompatible) version for GHC 9.2

@maerten maerten added status: needs triage type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. labels Mar 23, 2022
@drsooch
Copy link
Collaborator

drsooch commented Mar 23, 2022

Using cabal, 9.2.2 builds fine. Try updating the stack file, they sometimes fall out of sync.

@maerten
Copy link
Author

maerten commented Mar 23, 2022

Yep, 9.2.2 does compile, but the splice plugin seems to be disabled by default (in stack-9.2.yaml). what if you enable the splice plugin before compiling hls? Does that compile for you too?

@drsooch
Copy link
Collaborator

drsooch commented Mar 23, 2022

Ah yes, apologies. It's disabled in cabal-ghc92.project file.

@drsooch
Copy link
Collaborator

drsooch commented Mar 23, 2022

There is a meta-issue for 9.2.* support here: #2179

hls-splice-plugin was noted as working in 9.2.1, which is no longer true.

@drsooch drsooch added component: hls-splice-plugin ghc-9 and removed type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. status: needs triage labels Mar 23, 2022
@michaelpj michaelpj added GHC issues with particular GHC versions and removed old_ghc: 9 labels Jul 13, 2022
@michaelpj
Copy link
Collaborator

Old, and the configs have changed a lot since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: hls-splice-plugin GHC issues with particular GHC versions
Projects
None yet
Development

No branches or pull requests

3 participants