-
-
Notifications
You must be signed in to change notification settings - Fork 430
Open
Labels
component: formatterstype: bugSomething isn't right: doesn't work as intended, documentation is missing/outdated, etc..Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Description
If I try to format a file with an error (e.g. invalid syntax), using the built-in fourmolu plugin shows the error message in the notification, but using an external fourmolu simply shows "fourmolu: Internal Error: Fourmolu failed with exit code 3" in the notification, and you have to open the HLS logs to see the stderr
Seems specific to fourmolu:
haskell-language-server/plugins/hls-fourmolu-plugin/src/Ide/Plugin/Fourmolu.hs
Lines 147 to 148 in 66f5526
| logWith recorder Info $ StdErr err | |
| throwError $ PluginInternalError $ "Fourmolu failed with exit code " <> T.pack (show n) |
Perhaps we should put stderr in the InternalError? I think that would match the bundled fourmolu logic. cc @georgefst
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
component: formatterstype: bugSomething isn't right: doesn't work as intended, documentation is missing/outdated, etc..Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..