Skip to content

Flaky test "code actions -> hlint suggestions -> falls back to pre 3.8 code actions" #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maralorn opened this issue Nov 19, 2020 · 2 comments · Fixed by #643
Closed
Labels
can-workaround status: needs info Not actionable, because there's missing information type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@maralorn
Copy link
Contributor

I am trying to enable hls tests in nixpkgs. This test seems to fail only sometimes on my local system (a thinkpad notebook with nixos). This is with hls 0.6.0 and ghcide 0.5.0.

      falls back to pre 3.8 code actions:                                                               FAIL
        Exception: Timed out waiting to receive a message from the server.
        Last message received:
        {
            "tag": "RspExecuteCommand",
            "contents": {
                "result": null,
                "jsonrpc": "2.0",
                "id": 4
            }
        }
@jneira
Copy link
Member

jneira commented Nov 19, 2020

I've seen this error in other systems, including windows.
In ci we had to add three retries to make it pass almost all times (not only due this concrete test):

cabal test func-test --test-options="-j1 --rerun-update" || cabal test func-test --test-options="-j1 --rerun" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test func-test --test-options="-j1 --rerun"

Maybe it can alliviate the problems caused by flaky tests for you too

@jneira jneira added can-workaround status: needs info Not actionable, because there's missing information type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. type: testing labels Nov 19, 2020
@maralorn
Copy link
Contributor Author

Huh, thanks for the heads-up. Let's just say: That is not how we run our tests normally.^^
I have them disabled anyways for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can-workaround status: needs info Not actionable, because there's missing information type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
2 participants