Skip to content

Commit 59eb8df

Browse files
committed
Handle https.get errors properly
Might fix #272
1 parent a307e7a commit 59eb8df

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

src/hlsBinaries.ts

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -157,13 +157,17 @@ export async function downloadHaskellLanguageServer(
157157
path: '/repos/haskell/haskell-language-server/releases',
158158
headers: userAgentHeader,
159159
};
160-
https.get(opts, (res) => {
161-
res.on('data', (d) => (data += d));
162-
res.on('error', reject);
163-
res.on('close', () => {
164-
resolve(JSON.parse(data));
160+
https
161+
.get(opts, (res) => {
162+
res.on('data', (d) => (data += d));
163+
res.on('error', reject);
164+
res.on('close', () => {
165+
resolve(JSON.parse(data));
166+
});
167+
})
168+
.on('error', (e) => {
169+
reject(new Error(`Couldn't get the latest haskell-language-server releases from GitHub:\n${e.message}`));
165170
});
166-
});
167171
});
168172

169173
// Make sure to create this before getProjectGhcVersion

0 commit comments

Comments
 (0)