fix connection count bug

Author: hayes

.changeset/four-islands-juggle.md

@@ -0,0 +1,6 @@
+---
+"@pothos/plugin-drizzle": patch
+"@pothos/plugin-prisma": patch
+---
+
+Fix a bug where selecting only connection count at the same time as another field selected the same relation would cause an error"

packages/plugin-drizzle/src/drizzle-field-builder.ts

@@ -29,7 +29,14 @@ import {
   type Table,
   type TableRelationalConfig,
 } from 'drizzle-orm';
-import type { FieldNode } from 'graphql';
+import {
+  type FieldNode,
+  Kind as GraphQLKind,
+  type GraphQLResolveInfo,
+  getNamedType,
+  isInterfaceType,
+  isObjectType,
+} from 'graphql';
 import type { DrizzleRef } from './interface-ref';
 import type {
   DrizzleConnectionShape,
@@ -302,6 +309,7 @@ export class DrizzleObjectFieldBuilder<
           parent: unknown,
           args: PothosSchemaTypes.DefaultConnectionArguments,
           context: {},
+          info: GraphQLResolveInfo,
         ) => {
           const countKey = `_${name as string}_count`;
           const parentRecord = parent as Record<string, unknown>;
@@ -324,6 +332,34 @@ export class DrizzleObjectFieldBuilder<
             };
           }
 
+          // Detect totalCountOnly to skip cursor computation when only totalCount is requested
+          const returnType = getNamedType(info.returnType);
+          const fields =
+            isObjectType(returnType) || isInterfaceType(returnType) ? returnType.getFields() : {};
+          const totalCountOnly = info.fieldNodes.every((selection) =>
+            selection.selectionSet?.selections.every(
+              (s) =>
+                s.kind === GraphQLKind.FIELD &&
+                (fields[s.name.value]?.extensions?.pothosDrizzleTotalCount ||
+                  s.name.value === '__typename'),
+            ),
+          );
+
+          if (totalCountOnly) {
+            return {
+              parent,
+              args,
+              totalCount: countValue,
+              edges: [],
+              pageInfo: {
+                startCursor: null,
+                endCursor: null,
+                hasPreviousPage: false,
+                hasNextPage: false,
+              },
+            };
+          }
+
           const { select, cursorColumns } = getQuery(args, context);
 
           return wrapConnectionResult(
@@ -347,6 +383,9 @@ export class DrizzleObjectFieldBuilder<
                 ) => ({
                   totalCount: t.int({
                     nullable: false,
+                    extensions: {
+                      pothosDrizzleTotalCount: true,
+                    },
                     resolve: (connection) => connection.totalCount,
                   }),
                   ...(connectionOptions as { fields?: (t: unknown) => {} }).fields?.(t),

packages/plugin-drizzle/tests/__snapshots__/index.test.ts.snap

@@ -206,6 +206,7 @@ type User implements Node {
   id: ID!
   isAdmin: Boolean!
   lastName: String
+  postTitles: [String!]
   posts(limit: Int, offset: Int): [Post!]
   postsConnection(after: String, before: String, category: String, first: Int, invert: Boolean, last: Int, sortByCategory: Boolean): UserPostsConnection
   postsConnectionWithCount(after: String, before: String, first: Int, last: Int): UserPostsConnectionWithCountConnection

packages/plugin-drizzle/tests/example/schema.graphql

@@ -164,6 +164,7 @@ type User implements Node {
   id: ID!
   isAdmin: Boolean!
   lastName: String
+  postTitles: [String!]
   posts(limit: Int, offset: Int): [Post!]
   postsConnection(after: String, before: String, category: String, first: Int, invert: Boolean, last: Int, sortByCategory: Boolean): UserPostsConnection
   postsConnectionWithCount(after: String, before: String, first: Int, last: Int): UserPostsConnectionWithCountConnection

packages/plugin-drizzle/tests/example/schema/user.ts

@@ -292,6 +292,19 @@ export const User = builder.drizzleNode('users', {
         orderBy: { postId: 'desc' },
       }),
     }),
+    postTitles: t.stringList({
+      select: {
+        with: {
+          posts: {
+            columns: {
+              title: true,
+            },
+            limit: 3,
+          },
+        },
+      },
+      resolve: (user) => user.posts.map((p) => p.title),
+    }),
     viewer: t.variant(Viewer, {
       select: {
         columns: {

packages/plugin-drizzle/tests/related-connection.test.ts

@@ -1280,4 +1280,39 @@ describe('related connections', () => {
       }
     `);
   });
+
+  it('totalCount only with field selecting same relation without cursor (issue #1580)', async () => {
+    const context = await createContext({ userId: '1' });
+    clearDrizzleLogs();
+    const result = await execute({
+      schema,
+      document: gql`
+        query {
+          user(id: "VXNlcjox") {
+            postTitles
+            postsConnectionWithCount(first: 2) {
+              totalCount
+            }
+          }
+        }
+      `,
+      contextValue: context,
+    });
+
+    expect(result.errors).toBeUndefined();
+    expect(result.data).toMatchInlineSnapshot(`
+      {
+        "user": {
+          "postTitles": [
+            "Thalassinus ustilo hic civitas.",
+            "Altus suspendo textor ars teneo.",
+            "Terga depulso curia tenus.",
+          ],
+          "postsConnectionWithCount": {
+            "totalCount": 15,
+          },
+        },
+      }
+    `);
+  });
 });

packages/plugin-prisma/src/prisma-field-builder.ts

@@ -356,12 +356,25 @@ export class PrismaObjectFieldBuilder<
           parent: unknown,
           args: PothosSchemaTypes.DefaultConnectionArguments,
           context: {},
+          info: GraphQLResolveInfo,
         ) => {
+          const returnType = getNamedType(info.returnType);
+          const fields =
+            isObjectType(returnType) || isInterfaceType(returnType) ? returnType.getFields() : {};
+          const totalCountOnly = info.fieldNodes.every((selection) =>
+            selection.selectionSet?.selections.every(
+              (s) =>
+                s.kind === GraphQLKind.FIELD &&
+                (fields[s.name.value]?.extensions?.pothosPrismaTotalCount ||
+                  s.name.value === '__typename'),
+            ),
+          );
+
           const connectionQuery = getQuery(args, context);
 
           return wrapConnectionResult(
             parent,
-            (parent as Record<string, never>)[name] ?? [],
+            totalCountOnly ? [] : ((parent as Record<string, never>)[name] ?? []),
             args,
             connectionQuery.take,
             formatCursor,

packages/plugin-prisma/tests/__snapshots__/index.test.ts.snap

@@ -385,6 +385,7 @@ type SelectUser implements Node {
   id: ID!
   name: String
   postCount: Int!
+  postTitles: [String!]
   posts: [SelectPost!]
   postsConnection(after: String, before: String, first: Int, last: Int, oldestFirst: Boolean): SelectUserPostsConnection
   profile: Profile!

packages/plugin-prisma/tests/counts.test.ts

@@ -913,4 +913,39 @@ describe('prisma counts', () => {
       ]
     `);
   });
+
+  it('totalCount only with field selecting same relation without cursor (issue #1580)', async () => {
+    const query = gql`
+      query {
+        selectMe {
+          postTitles
+          postsConnection {
+            totalCount
+          }
+        }
+      }
+    `;
+
+    const result = await execute({
+      schema,
+      document: query,
+      contextValue: { user: { id: 1 } },
+    });
+
+    expect(result.errors).toBeUndefined();
+    expect(result.data).toMatchInlineSnapshot(`
+      {
+        "selectMe": {
+          "postTitles": [
+            "Quos distinctio distinctio dignissimos vel quo maiores ea.",
+            "Voluptatem eum dolores dignissimos quia vel.",
+            "Ut corrupti eum nostrum consequatur aliquam nostrum.",
+          ],
+          "postsConnection": {
+            "totalCount": 250,
+          },
+        },
+      }
+    `);
+  });
 });

packages/plugin-prisma/tests/example/schema/index.ts

@@ -558,6 +558,15 @@ const SelectUser = builder.prismaNode('User', {
       onNull: 'error',
     }),
     postCount: t.relationCount('posts'),
+    postTitles: t.stringList({
+      select: {
+        posts: {
+          select: { title: true },
+          take: 3,
+        },
+      },
+      resolve: (user) => user.posts.map((p) => p.title),
+    }),
     following: t.relatedConnection('following', {
       complexity: (args) => args.first ?? 1,
       cursor: 'compositeID',