Prevent duplicate image loading (go-gitea#25675) (go-gitea#25684)

GiteaBot · delvh · web-flow · commit 4e310133f95b · 2023-07-04T14:49:39.000Z
Backport go-gitea#25675 by @delvh Regression of go-gitea#25672. Co-authored-by: delvh <dev.lh@web.de>
diff --git a/web_src/js/features/imagediff.js b/web_src/js/features/imagediff.js
@@ -65,8 +65,9 @@ export function initImageDiff() {
     };
   }
 
-  $('.image-diff').each(function() {
+  $('.image-diff:not([data-image-diff-loaded])').each(function() {
     const $container = $(this);
+    $container.attr('data-image-diff-loaded', 'true');
 
     // the container may be hidden by "viewed" checkbox, so use the parent's width for reference
     const diffContainerWidth = Math.max($container.closest('.diff-file-box').width() - 300, 100);

Original file line number	Diff line number	Diff line change
`@@ -65,8 +65,9 @@ export function initImageDiff() {`
`65`	`65`	`};`
`66`	`66`	`}`
`67`	`67`
`68`		`- $('.image-diff').each(function() {`
	`68`	`+ $('.image-diff:not([data-image-diff-loaded])').each(function() {`
`69`	`69`	`const $container = $(this);`
	`70`	`+ $container.attr('data-image-diff-loaded', 'true');`
`70`	`71`
`71`	`72`	`// the container may be hidden by "viewed" checkbox, so use the parent's width for reference`
`72`	`73`	`const diffContainerWidth = Math.max($container.closest('.diff-file-box').width() - 300, 100);`