Fix text_input::Renderer implementation in iced_wgpu#279
Merged
Conversation
It accounts for spaces at the start of text now.
It should only produce a `Clip` primitive when the contents overflow the input now.
hecrj
force-pushed
the
fix/text-input-measure-value
branch
from
1a7f097 to
d3dee84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes and improves the
text_input::Rendererimplementation iniced_wgpu. Specifically:measure_valueimplementation, which was incorrectly measuring text when spaces were present at the start.drawimplementation only produce aClipprimitive when the text value overflows the input. This should improve performance, asClipprimitives are currently very expensive.