Skip to content

Commit 7e7f843

Browse files
committed
Revert "temp fix unit tests"
This reverts commit cb8c6f2.
1 parent 415a718 commit 7e7f843

File tree

2 files changed

+7
-11
lines changed

2 files changed

+7
-11
lines changed

tests/Unit/Component/Actionlogs/Administrator/Model/ActionlogConfigModelTest.php

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
use Joomla\CMS\MVC\Factory\MVCFactoryInterface;
1414
use Joomla\Component\Actionlogs\Administrator\Model\ActionlogConfigModel;
15-
use Joomla\Database\DatabaseDriver;
15+
use Joomla\Database\DatabaseInterface;
1616
use Joomla\Tests\Unit\UnitTestCase;
1717

1818
/**
@@ -33,10 +33,9 @@ class ActionlogConfigModelTest extends UnitTestCase
3333
*/
3434
public function testGetLogContentTypeParams()
3535
{
36-
/* @todo: Return to DatabaseInterface when createQuery is implemented in the interface */
3736
$config = new \stdClass();
38-
$db = $this->createStub(DatabaseDriver::class);
39-
$db->method('createQuery')->willReturn($this->getQueryStub($db));
37+
$db = $this->createStub(DatabaseInterface::class);
38+
$db->method('getQuery')->willReturn($this->getQueryStub($db));
4039
$db->method('loadObject')->willReturn($config);
4140

4241
$model = new ActionlogConfigModel(['dbo' => $db], $this->createStub(MVCFactoryInterface::class));
@@ -53,9 +52,8 @@ public function testGetLogContentTypeParams()
5352
*/
5453
public function testGetNullLogContentTypeParams()
5554
{
56-
/* @todo: Return to DatabaseInterface when createQuery is implemented in the interface */
57-
$db = $this->createStub(DatabaseDriver::class);
58-
$db->method('createQuery')->willReturn($this->getQueryStub($db));
55+
$db = $this->createStub(DatabaseInterface::class);
56+
$db->method('getQuery')->willReturn($this->getQueryStub($db));
5957

6058
$model = new ActionlogConfigModel(['dbo' => $db], $this->createStub(MVCFactoryInterface::class));
6159

tests/Unit/Libraries/Cms/MVC/Model/DatabaseModelTest.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
use Joomla\CMS\MVC\Model\DatabaseAwareTrait;
1717
use Joomla\CMS\Table\Table;
1818
use Joomla\CMS\User\User;
19-
use Joomla\Database\DatabaseDriver;
2019
use Joomla\Database\DatabaseInterface;
2120
use Joomla\Tests\Unit\UnitTestCase;
2221

@@ -129,10 +128,9 @@ public function _getList($query, $limitstart = 0, $limit = 0)
129128
*/
130129
public function testGetListFromString()
131130
{
132-
/* @todo: Return to DatabaseInterface when createQuery is implemented in the interface */
133-
$db = $this->createStub(DatabaseDriver::class);
131+
$db = $this->createStub(DatabaseInterface::class);
134132
$db->method('loadObjectList')->willReturn([1]);
135-
$db->method('createQuery')->willReturn($this->getQueryStub($db));
133+
$db->method('getQuery')->willReturn($this->getQueryStub($db));
136134

137135
$model = new class (['dbo' => $db], $this->createStub(MVCFactoryInterface::class)) extends BaseDatabaseModel {
138136
public function _getList($query, $limitstart = 0, $limit = 0)

0 commit comments

Comments
 (0)