Reject u16::MAX in OneBased::from_zero_based

the-mikedavis · the-mikedavis · commit acfd456c9303 · 2026-05-26T09:55:17.000-04:00
`Option::&lt;T&gt;::unwrap` is not stable on the MSRV so we need to use an
assertion instead.
diff --git a/src/lib.rs b/src/lib.rs
@@ -34,7 +34,8 @@ impl OneBased {
     }
 
     pub const fn from_zero_based(n: u16) -> Self {
-        OneBased(NonZeroU16::new(n).unwrap())
+        assert!(n < u16::MAX);
+        Self(unsafe { NonZeroU16::new_unchecked(n + 1) })
     }
 
     pub const fn get(self) -> u16 {

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,8 @@ impl OneBased {`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`pub const fn from_zero_based(n: u16) -> Self {`
`37`		`- OneBased(NonZeroU16::new(n).unwrap())`
	`37`	`+ assert!(n < u16::MAX);`
	`38`	`+ Self(unsafe { NonZeroU16::new_unchecked(n + 1) })`
`38`	`39`	`}`
`39`	`40`
`40`	`41`	`pub const fn get(self) -> u16 {`