Skip to content

Commit 04f7a60

Browse files
authored
feat: Challenge redislabs-training#2
1 parent 0ceb142 commit 04f7a60

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

redisolar/dao/redis/metric.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,8 @@ def insert_metric(self, site_id: int, value: float, unit: MetricUnit,
120120
minute_of_day = self._get_day_minute(time) # pylint: disable=unused-variable
121121

122122
# START Challenge #2
123+
pipeline.zadd(metric_key, {f'{value}:{minute_of_day}': minute_of_day})
124+
pipeline.expire(metric_key, METRIC_EXPIRATION_SECONDS)
123125
# END Challenge #2
124126

125127
def get_recent(self, site_id: int, unit: MetricUnit, time: datetime.datetime,

tests/dao/redis/test_metric.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,16 +49,13 @@ def _test_insert_and_retrieve(readings: List[MeterReading],
4949

5050

5151
# Challenge #2
52-
@pytest.mark.skip("Remove for challenge #2")
5352
def test_small(metric_dao, readings):
5453
_test_insert_and_retrieve(readings, metric_dao, 1)
5554

5655

57-
@pytest.mark.skip("Remove for challenge #2")
5856
def test_one_day(metric_dao, readings):
5957
_test_insert_and_retrieve(readings, metric_dao, 60 * 24)
6058

6159

62-
@pytest.mark.skip("Remove for challenge #2")
6360
def test_multiple_days(metric_dao, readings):
6461
_test_insert_and_retrieve(readings, metric_dao, 60 * 70)

0 commit comments

Comments
 (0)