Skip to content

Commit 85fa288

Browse files
committed
HHH-20341 Fix syntax of maven mirror definition
As it was, it was simply being ignored.
1 parent c17bd33 commit 85fa288

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

MAINTAINERS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ Continuous integration is split across two platforms:
2020
The Hibernate ORM build can use a mirror instead of Maven central.
2121
To do so, set the `MAVEN_MIRROR` environment variable to the URL of your mirror,
2222
e.g. `http://something-on-aws.com/path/to/repo`.
23+
The mirror can use unsecure HTTP, but obviously that exposes you to MITM attacks unless the build runs in a completely isolated network.
2324

2425
### GitHub Actions workflows
2526

settings.gradle

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,10 @@ dependencyResolutionManagement {
2828
// TODO Move to infra overrides instead;
2929
// see https://blog.gradle.org/maven-central-mirror#overriding-the-urls-for-maven-central-and-the-plugin-portal-repositories
3030
if ( System.env['MAVEN_MIRROR'] ) {
31-
url( System.env['MAVEN_MIRROR'] )
31+
maven {
32+
url System.env['MAVEN_MIRROR']
33+
allowInsecureProtocol = true
34+
}
3235
}
3336

3437
mavenCentral()

0 commit comments

Comments
 (0)