-
Notifications
You must be signed in to change notification settings - Fork 32
Rdm 3330 document links fix #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rdm 3330 document links fix #280
Conversation
// Current behaviour is that system will hang for a very long time | ||
throw new AppConfigurationException("Cloub Blob Container does not exist"); | ||
} | ||
return container; | ||
} | ||
|
||
protected boolean shouldCheckExistence() { | ||
return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introduced as a testability support for the class, and used later in fixing an issue in mocking of the class emerged after boot upgrade.
Codecov Report
@@ Coverage Diff @@
## RDM-2506_SpringBoot_Upgrade #280 +/- ##
==============================================================
Coverage 91.27% 91.27%
Complexity 315 315
==============================================================
Files 55 55
Lines 883 883
Branches 64 64
==============================================================
Hits 806 806
Misses 48 48
Partials 29 29
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…o RDM-3330_Document_Links_Fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Useful links about the solution approach for this defect, for future reference: |
…o RDM-3330_Document_Links_Fix
…o RDM-3330_Document_Links_Fix
…o RDM-3330_Document_Links_Fix
RDM-3330_Document_Links_Fix Conflicts: application/build.gradle
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Jira Link for this change: https://tools.hmcts.net/jira/browse/RDM-3330