Skip to content

Rdm 3330 document links fix #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

MSancaktutar
Copy link

@MSancaktutar MSancaktutar commented Mar 5, 2019

Jira Link for this change: https://tools.hmcts.net/jira/browse/RDM-3330

[ ] Yes
[X] No

// Current behaviour is that system will hang for a very long time
throw new AppConfigurationException("Cloub Blob Container does not exist");
}
return container;
}

protected boolean shouldCheckExistence() {
return true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Copy link
Author

@MSancaktutar MSancaktutar Mar 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduced as a testability support for the class, and used later in fixing an issue in mocking of the class emerged after boot upgrade.

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #280 into RDM-2506_SpringBoot_Upgrade will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                      Coverage Diff                       @@
##             RDM-2506_SpringBoot_Upgrade     #280   +/-   ##
==============================================================
  Coverage                          91.27%   91.27%           
  Complexity                           315      315           
==============================================================
  Files                                 55       55           
  Lines                                883      883           
  Branches                              64       64           
==============================================================
  Hits                                 806      806           
  Misses                                48       48           
  Partials                              29       29
Impacted Files Coverage Δ Complexity Δ
.../dm/controller/StoredDocumentUpdateController.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...ervice/AuditedStoredDocumentOperationsService.java 100% <ø> (ø) 15 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98410ae...14fc969. Read the comment docs.

@MSancaktutar MSancaktutar changed the base branch from master to RDM-2506_SpringBoot_Upgrade March 5, 2019 14:52
Copy link
Contributor

@rafalkalita rafalkalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mario-paniccia mario-paniccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MSancaktutar
Copy link
Author

@stale
Copy link

stale bot commented Apr 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 18, 2019
@stale stale bot removed the stale label May 24, 2019
@stale
Copy link

stale bot commented Jun 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants