add sound mode support for devices that support it

Author: raman325

homeassistant/components/vizio/media_player.py

@@ -9,6 +9,7 @@
 
 from homeassistant.components.media_player import (
     DEVICE_CLASS_SPEAKER,
+    SUPPORT_SELECT_SOUND_MODE,
     MediaPlayerDevice,
 )
 from homeassistant.config_entries import ConfigEntry
@@ -133,6 +134,8 @@ def __init__(
         self._current_input = None
         self._current_app = None
         self._current_app_config = None
+        self._current_sound_mode = None
+        self._available_sound_modes = None
         self._available_inputs = []
         self._available_apps = []
         self._conf_apps = config_entry.options.get(CONF_APPS, {})
@@ -191,17 +194,31 @@ async def async_update(self) -> None:
             self._current_app = None
             self._current_app_config = None
             self._available_apps = None
+            self._current_sound_mode = None
+            self._available_sound_modes = None
             return
 
         self._state = STATE_ON
 
-        audio_settings = await self._device.get_all_audio_settings(
-            log_api_exception=False
+        audio_settings = await self._device.get_all_settings(
+            "audio", log_api_exception=False
         )
         if audio_settings is not None:
             self._volume_level = float(audio_settings["volume"]) / self._max_volume
             self._is_muted = audio_settings["mute"].lower() == "on"
 
+            if "eq" in audio_settings:
+                self._supported_commands = (
+                    SUPPORTED_COMMANDS[self._device_class] | SUPPORT_SELECT_SOUND_MODE
+                )
+                self._current_sound_mode = audio_settings["eq"]
+                if self._available_sound_modes is None:
+                    self._available_sound_modes = await self._device.get_setting_options(
+                        "audio", "eq"
+                    )
+            else:
+                self._supported_commands = SUPPORTED_COMMANDS[self._device_class]
+
         input_ = await self._device.get_current_input(log_api_exception=False)
         if input_ is not None:
             self._current_input = input_
@@ -367,7 +384,7 @@ def unique_id(self) -> str:
         return self._config_entry.unique_id
 
     @property
-    def device_info(self):
+    def device_info(self) -> Dict[str, Any]:
         """Return device registry information."""
         return {
             "identifiers": {(DOMAIN, self._config_entry.unique_id)},
@@ -378,10 +395,25 @@ def device_info(self):
         }
 
     @property
-    def device_class(self):
+    def device_class(self) -> str:
         """Return device class for entity."""
         return self._device_class
 
+    @property
+    def sound_mode(self) -> Optional[str]:
+        """Name of the current sound mode."""
+        return self._current_sound_mode
+
+    @property
+    def sound_mode_list(self) -> Optional[List[str]]:
+        """List of available sound modes."""
+        return self._available_sound_modes
+
+    async def async_select_sound_mode(self, sound_mode):
+        """Select sound mode."""
+        if sound_mode in self._available_sound_modes:
+            await self._device.set_setting("audio", "eq", sound_mode)
+
     async def async_turn_on(self) -> None:
         """Turn the device on."""
         await self._device.pow_on()

tests/components/vizio/conftest.py

@@ -8,7 +8,9 @@
     APP_LIST,
     CH_TYPE,
     CURRENT_APP_CONFIG,
+    CURRENT_EQ,
     CURRENT_INPUT,
+    EQ_LIST,
     INPUT_LIST,
     INPUT_LIST_WITH_APPS,
     MODEL,
@@ -135,11 +137,15 @@ def vizio_update_fixture():
         "homeassistant.components.vizio.media_player.VizioAsync.can_connect_with_auth_check",
         return_value=True,
     ), patch(
-        "homeassistant.components.vizio.media_player.VizioAsync.get_all_audio_settings",
+        "homeassistant.components.vizio.media_player.VizioAsync.get_all_settings",
         return_value={
             "volume": int(MAX_VOLUME[DEVICE_CLASS_SPEAKER] / 2),
+            "eq": CURRENT_EQ,
             "mute": "Off",
         },
+    ), patch(
+        "homeassistant.components.vizio.media_player.VizioAsync.get_setting_options",
+        return_value=EQ_LIST,
     ), patch(
         "homeassistant.components.vizio.media_player.VizioAsync.get_current_input",
         return_value=CURRENT_INPUT,

tests/components/vizio/const.py

@@ -64,6 +64,9 @@ def __init__(self, auth_token: str) -> None:
         self.auth_token = auth_token
 
 
+CURRENT_EQ = "Music"
+EQ_LIST = ["Music", "Movie"]
+
 CURRENT_INPUT = "HDMI"
 INPUT_LIST = ["HDMI", "USB", "Bluetooth", "AUX"]
 

tests/components/vizio/test_media_player.py

@@ -21,11 +21,13 @@
     ATTR_INPUT_SOURCE,
     ATTR_MEDIA_VOLUME_LEVEL,
     ATTR_MEDIA_VOLUME_MUTED,
+    ATTR_SOUND_MODE,
     DEVICE_CLASS_SPEAKER,
     DEVICE_CLASS_TV,
     DOMAIN as MP_DOMAIN,
     SERVICE_MEDIA_NEXT_TRACK,
     SERVICE_MEDIA_PREVIOUS_TRACK,
+    SERVICE_SELECT_SOUND_MODE,
     SERVICE_SELECT_SOURCE,
     SERVICE_TURN_OFF,
     SERVICE_TURN_ON,
@@ -58,9 +60,11 @@
     APP_LIST,
     CURRENT_APP,
     CURRENT_APP_CONFIG,
+    CURRENT_EQ,
     CURRENT_INPUT,
     CUSTOM_CONFIG,
     ENTITY_ID,
+    EQ_LIST,
     INPUT_LIST,
     INPUT_LIST_WITH_APPS,
     MOCK_SPEAKER_APPS_FAILURE,
@@ -99,17 +103,29 @@ async def _test_setup(
             data=vol.Schema(VIZIO_SCHEMA)(MOCK_SPEAKER_CONFIG),
             unique_id=UNIQUE_ID,
         )
+        dict_to_return = {
+            "volume": int(MAX_VOLUME[vizio_device_class] / 2),
+            "mute": "Off",
+            "eq": CURRENT_EQ,
+        }
     else:
         vizio_device_class = VIZIO_DEVICE_CLASS_TV
         config_entry = MockConfigEntry(
             domain=DOMAIN,
             data=vol.Schema(VIZIO_SCHEMA)(MOCK_USER_VALID_TV_CONFIG),
             unique_id=UNIQUE_ID,
         )
+        dict_to_return = {
+            "volume": int(MAX_VOLUME[vizio_device_class] / 2),
+            "mute": "Off",
+        }
 
     with patch(
-        "homeassistant.components.vizio.media_player.VizioAsync.get_all_audio_settings",
-        return_value={"volume": int(MAX_VOLUME[vizio_device_class] / 2), "mute": "Off"},
+        "homeassistant.components.vizio.media_player.VizioAsync.get_all_settings",
+        return_value=dict_to_return,
+    ), patch(
+        "homeassistant.components.vizio.media_player.VizioAsync.get_setting_options",
+        return_value=EQ_LIST,
     ), patch(
         "homeassistant.components.vizio.media_player.VizioAsync.get_power_state",
         return_value=vizio_power_state,
@@ -130,6 +146,9 @@ async def _test_setup(
             assert attr["source"] == CURRENT_INPUT
             if ha_device_class == DEVICE_CLASS_SPEAKER:
                 assert not service_call.called
+                assert "sound_mode" in attr
+            else:
+                assert "sound_mode" not in attr
             assert (
                 attr["volume_level"]
                 == float(int(MAX_VOLUME[vizio_device_class] / 2))
@@ -149,7 +168,7 @@ async def _test_setup_with_apps(
     )
 
     with patch(
-        "homeassistant.components.vizio.media_player.VizioAsync.get_all_audio_settings",
+        "homeassistant.components.vizio.media_player.VizioAsync.get_all_settings",
         return_value={
             "volume": int(MAX_VOLUME[VIZIO_DEVICE_CLASS_TV] / 2),
             "mute": "Off",
@@ -351,6 +370,9 @@ async def test_services(
     )
     await _test_service(hass, "ch_up", SERVICE_MEDIA_NEXT_TRACK, None)
     await _test_service(hass, "ch_down", SERVICE_MEDIA_PREVIOUS_TRACK, None)
+    await _test_service(
+        hass, "set_setting", SERVICE_SELECT_SOUND_MODE, {ATTR_SOUND_MODE: "Music"}
+    )
 
 
 async def test_options_update(