Skip to content

Commit d3ed80c

Browse files
authored
Rename VacuumDevice to VacuumEntity (#34674)
1 parent 90e0a1a commit d3ed80c

File tree

12 files changed

+66
-24
lines changed

12 files changed

+66
-24
lines changed

homeassistant/components/demo/vacuum.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
SUPPORT_STOP,
2222
SUPPORT_TURN_OFF,
2323
SUPPORT_TURN_ON,
24-
StateVacuumDevice,
25-
VacuumDevice,
24+
StateVacuumEntity,
25+
VacuumEntity,
2626
)
2727

2828
_LOGGER = logging.getLogger(__name__)
@@ -95,7 +95,7 @@ async def async_setup_platform(hass, config, async_add_entities, discovery_info=
9595
)
9696

9797

98-
class DemoVacuum(VacuumDevice):
98+
class DemoVacuum(VacuumEntity):
9999
"""Representation of a demo vacuum."""
100100

101101
def __init__(self, name, supported_features):
@@ -254,7 +254,7 @@ def send_command(self, command, params=None, **kwargs):
254254
self.schedule_update_ha_state()
255255

256256

257-
class StateDemoVacuum(StateVacuumDevice):
257+
class StateDemoVacuum(StateVacuumEntity):
258258
"""Representation of a demo vacuum supporting states."""
259259

260260
def __init__(self, name):

homeassistant/components/dyson/vacuum.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
SUPPORT_STOP,
1414
SUPPORT_TURN_OFF,
1515
SUPPORT_TURN_ON,
16-
VacuumDevice,
16+
VacuumEntity,
1717
)
1818
from homeassistant.helpers.icon import icon_for_battery_level
1919

@@ -54,7 +54,7 @@ def setup_platform(hass, config, add_entities, discovery_info=None):
5454
return True
5555

5656

57-
class Dyson360EyeDevice(VacuumDevice):
57+
class Dyson360EyeDevice(VacuumEntity):
5858
"""Dyson 360 Eye robot vacuum device."""
5959

6060
def __init__(self, device):

homeassistant/components/ecovacs/vacuum.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
SUPPORT_STOP,
1515
SUPPORT_TURN_OFF,
1616
SUPPORT_TURN_ON,
17-
VacuumDevice,
17+
VacuumEntity,
1818
)
1919
from homeassistant.helpers.icon import icon_for_battery_level
2020

@@ -48,7 +48,7 @@ def setup_platform(hass, config, add_entities, discovery_info=None):
4848
add_entities(vacuums, True)
4949

5050

51-
class EcovacsVacuum(VacuumDevice):
51+
class EcovacsVacuum(VacuumEntity):
5252
"""Ecovacs Vacuums such as Deebot."""
5353

5454
def __init__(self, device):

homeassistant/components/mqtt/vacuum/schema_legacy.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
SUPPORT_STOP,
2626
SUPPORT_TURN_OFF,
2727
SUPPORT_TURN_ON,
28-
VacuumDevice,
28+
VacuumEntity,
2929
)
3030
from homeassistant.const import ATTR_SUPPORTED_FEATURES, CONF_DEVICE, CONF_NAME
3131
from homeassistant.core import callback
@@ -174,7 +174,7 @@ class MqttVacuum(
174174
MqttAvailability,
175175
MqttDiscoveryUpdate,
176176
MqttEntityDeviceInfo,
177-
VacuumDevice,
177+
VacuumEntity,
178178
):
179179
"""Representation of a MQTT-controlled legacy vacuum."""
180180

homeassistant/components/mqtt/vacuum/schema_state.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
SUPPORT_START,
3535
SUPPORT_STATUS,
3636
SUPPORT_STOP,
37-
StateVacuumDevice,
37+
StateVacuumEntity,
3838
)
3939
from homeassistant.const import ATTR_SUPPORTED_FEATURES, CONF_DEVICE, CONF_NAME
4040
from homeassistant.core import callback
@@ -162,7 +162,7 @@ class MqttStateVacuum(
162162
MqttAvailability,
163163
MqttDiscoveryUpdate,
164164
MqttEntityDeviceInfo,
165-
StateVacuumDevice,
165+
StateVacuumEntity,
166166
):
167167
"""Representation of a MQTT-controlled state vacuum."""
168168

homeassistant/components/neato/vacuum.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
SUPPORT_START,
2323
SUPPORT_STATE,
2424
SUPPORT_STOP,
25-
StateVacuumDevice,
25+
StateVacuumEntity,
2626
)
2727
from homeassistant.const import ATTR_ENTITY_ID, ATTR_MODE
2828
import homeassistant.helpers.config_validation as cv
@@ -126,7 +126,7 @@ def service_to_entities(call):
126126
)
127127

128128

129-
class NeatoConnectedVacuum(StateVacuumDevice):
129+
class NeatoConnectedVacuum(StateVacuumEntity):
130130
"""Representation of a Neato Connected Vacuum."""
131131

132132
def __init__(self, neato, robot, mapdata, persistent_maps):

homeassistant/components/roomba/irobot_base.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
SUPPORT_START,
1818
SUPPORT_STATE,
1919
SUPPORT_STOP,
20-
StateVacuumDevice,
20+
StateVacuumEntity,
2121
)
2222
from homeassistant.helpers.entity import Entity
2323

@@ -104,7 +104,7 @@ def on_message(self, json_data):
104104
self.schedule_update_ha_state()
105105

106106

107-
class IRobotVacuum(IRobotEntity, StateVacuumDevice):
107+
class IRobotVacuum(IRobotEntity, StateVacuumEntity):
108108
"""Base class for iRobot robots."""
109109

110110
def __init__(self, roomba, blid):

homeassistant/components/template/vacuum.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
SUPPORT_START,
2929
SUPPORT_STATE,
3030
SUPPORT_STOP,
31-
StateVacuumDevice,
31+
StateVacuumEntity,
3232
)
3333
from homeassistant.const import (
3434
CONF_ENTITY_ID,
@@ -144,7 +144,7 @@ async def async_setup_platform(hass, config, async_add_entities, discovery_info=
144144
async_add_entities(vacuums)
145145

146146

147-
class TemplateVacuum(StateVacuumDevice):
147+
class TemplateVacuum(StateVacuumEntity):
148148
"""A template vacuum component."""
149149

150150
def __init__(

homeassistant/components/vacuum/__init__.py

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ async def async_send_command(self, command, params=None, **kwargs):
228228
)
229229

230230

231-
class VacuumDevice(_BaseVacuum, ToggleEntity):
231+
class VacuumEntity(_BaseVacuum, ToggleEntity):
232232
"""Representation of a vacuum cleaner robot."""
233233

234234
@property
@@ -309,7 +309,19 @@ async def async_start(self):
309309
"""Not supported."""
310310

311311

312-
class StateVacuumDevice(_BaseVacuum):
312+
class VacuumDevice(VacuumEntity):
313+
"""Representation of a vacuum (for backwards compatibility)."""
314+
315+
def __init_subclass__(cls, **kwargs):
316+
"""Print deprecation warning."""
317+
super().__init_subclass__(**kwargs)
318+
_LOGGER.warning(
319+
"VacuumDevice is deprecated, modify %s to extend VacuumEntity",
320+
cls.__name__,
321+
)
322+
323+
324+
class StateVacuumEntity(_BaseVacuum):
313325
"""Representation of a vacuum cleaner robot that supports states."""
314326

315327
@property
@@ -377,3 +389,15 @@ async def async_turn_off(self, **kwargs):
377389

378390
async def async_toggle(self, **kwargs):
379391
"""Not supported."""
392+
393+
394+
class StateVacuumDevice(StateVacuumEntity):
395+
"""Representation of a vacuum (for backwards compatibility)."""
396+
397+
def __init_subclass__(cls, **kwargs):
398+
"""Print deprecation warning."""
399+
super().__init_subclass__(**kwargs)
400+
_LOGGER.warning(
401+
"StateVacuumDevice is deprecated, modify %s to extend StateVacuumEntity",
402+
cls.__name__,
403+
)

homeassistant/components/xiaomi_miio/vacuum.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
SUPPORT_START,
2626
SUPPORT_STATE,
2727
SUPPORT_STOP,
28-
StateVacuumDevice,
28+
StateVacuumEntity,
2929
)
3030
from homeassistant.const import (
3131
ATTR_ENTITY_ID,
@@ -229,7 +229,7 @@ async def async_service_handler(service):
229229
)
230230

231231

232-
class MiroboVacuum(StateVacuumDevice):
232+
class MiroboVacuum(StateVacuumEntity):
233233
"""Representation of a Xiaomi Vacuum cleaner robot."""
234234

235235
def __init__(self, name, vacuum):

0 commit comments

Comments
 (0)