Housekeeping: Normalize test file names, build clean

Normalize test file naming to *-error.cpp2
Make GCC and Clang build clean

Author: hsutter

…ssion-tests/pure2-deducing-pointers.cpp2 …tests/pure2-deducing-pointers-error.cpp2regression-tests/pure2-deducing-pointers.cpp2 renamed to regression-tests/pure2-deducing-pointers-error.cpp2 regression-tests/pure2-deducing-pointers.cpp2 renamed to regression-tests/pure2-deducing-pointers-error.cpp2

@@ -0,0 +1,12 @@
+pure2-deducing-pointers-error.cpp2...
+pure2-deducing-pointers-error.cpp2(14,8): error: = - pointer assignment from null or integer is illegal
+pure2-deducing-pointers-error.cpp2(17,9): error: = - pointer assignment from null or integer is illegal
+pure2-deducing-pointers-error.cpp2(20,9): error: = - pointer assignment from null or integer is illegal
+pure2-deducing-pointers-error.cpp2(21,9): error: += - pointer assignment from null or integer is illegal
+pure2-deducing-pointers-error.cpp2(25,9): error: = - pointer assignment from null or integer is illegal
+pure2-deducing-pointers-error.cpp2(29,9): error: = - pointer assignment from null or integer is illegal
+pure2-deducing-pointers-error.cpp2(31,11): error: ++ - pointer arithmetic is illegal - use std::span or gsl::span instead
+pure2-deducing-pointers-error.cpp2(33,8): error: = - pointer assignment from null or integer is illegal
+  ==> program violates lifetime safety guarantee - see previous errors
+  ==> program violates bounds safety guarantee - see previous errors
+

regression-tests/test-results/pure2-deducing-pointers-error.cpp2.output

@@ -1607,7 +1607,7 @@ class cppfront
     }
 
     // Don't work yet, TODO: finalize deducing pointer types from parameter lists
-    auto is_pointer_declaration(parameter_declaration_list_node const* decl_node, int deref_cnt, int addr_cnt) -> bool {
+    auto is_pointer_declaration(parameter_declaration_list_node const*, int, int) -> bool {
         return false;
     }
 

regression-tests/test-results/pure2-deducing-pointers.cpp2.output

@@ -338,9 +338,6 @@ auto expand_string_literal(std::string_view text, std::vector<error>& errors, so
             auto paren_depth = 1;
             auto open = pos - 2;
 
-            //  "next" in the string is the "last" one encountered in the backwards scan
-            auto last_nonwhitespace = '\0';
-
             for( ; text[open] != '"' || (open > current_start && text[open-1] != '\\'); --open)
             {
                 if (text[open] == ')') {
@@ -352,10 +349,6 @@ auto expand_string_literal(std::string_view text, std::vector<error>& errors, so
                         break;
                     }
                 }
-
-                if (!std::isspace(text[open])) {
-                    last_nonwhitespace = text[open];
-                }
             }
             if (text[open] == '"')
             {

source/cppfront.cpp

@@ -226,7 +226,7 @@ class sema
     {
     }
 
-    //  Get the declaration of t within the same named function or beyound it
+    //  Get the declaration of t within the same named function or beyond it
     //
     auto get_declaration_of(token const& t, bool look_beyond_current_function = false) -> declaration_sym const*
     {