Get /W4 and -Wall -Wextra clean again, closes #173

Author: hsutter

source/cppfront.cpp

@@ -652,8 +652,8 @@ class cppfront
     bool suppress_move_from_last_use    = false;
 
     struct arg_info {
-        passing_style pass  = passing_style::in;
-        token const*  token = nullptr;
+        passing_style pass   = passing_style::in;
+        token const*  ptoken = nullptr;
     };
     std::vector<arg_info> current_args  = { {} };
 
@@ -1099,7 +1099,7 @@ class cppfront
         //  For an explicit 'forward' apply forwarding to correct identifier
         assert (!current_args.empty());
         if (current_args.back().pass == passing_style::forward) {
-            add_std_forward = current_args.back().token == n.identifier;
+            add_std_forward = current_args.back().ptoken == n.identifier;
         }
 
         if (add_std_move) {
@@ -1628,9 +1628,9 @@ class cppfront
         if (current_args.back().pass == passing_style::forward)
         {
             assert (n.expr->get_token());
-            assert (!current_args.back().token);
-            current_args.back().token = n.expr->get_token();
-            auto decl = sema.get_local_declaration_of(*current_args.back().token);
+            assert (!current_args.back().ptoken);
+            current_args.back().ptoken = n.expr->get_token();
+            auto decl = sema.get_local_declaration_of(*current_args.back().ptoken);
             if (!(decl && decl->parameter && decl->parameter->pass == passing_style::forward)) {
                 errors.emplace_back(
                     n.position(),

source/load.h

@@ -382,8 +382,7 @@ auto process_cpp_line(
     bool&               in_raw_string_literal,
     std::string&        raw_string_closing_seq,
     braces_tracker&     braces,
-    lineno_t            lineno,
-    std::vector<error>& errors
+    lineno_t            lineno
 )
     -> process_line_ret
 {
@@ -637,6 +636,8 @@ class source
                     braces.found_pre_else();
                 break;case preprocessor_conditional::pre_endif:
                     braces.found_pre_endif();
+                break;default:
+                    assert(false);
                 }
             }
         };
@@ -714,8 +715,7 @@ class source
                             in_raw_string_literal,
                             raw_string_closing_seq,
                             braces,
-                            std::ssize(lines) - 1,
-                            errors
+                            std::ssize(lines) - 1
                         );
                         if (stats.all_comment_line) {
                             lines.back().cat = source_line::category::comment;