Merge pull request #80 from filipsajdak/fsajdak-fix-is-pointer-dynamic-cast

hsutter · web-flow · commit bd218d0c6f92 · 2022-10-17T17:32:58.000-07:00
[FIX] Correct casting to pointer instead of reference
diff --git a/include/cpp2util.h b/include/cpp2util.h
@@ -539,7 +539,7 @@ auto is( X const& x ) -> bool {
 template< typename C, typename X >
     requires (std::is_base_of_v<X, C> && !std::is_same_v<C,X>)
 auto is( X const* x ) -> bool {
-    return dynamic_cast<C const&>(x) != nullptr;
+    return dynamic_cast<C const*>(x) != nullptr;
 }
 
 template< typename C, typename X >

Original file line number	Diff line number	Diff line change
`@@ -539,7 +539,7 @@ auto is( X const& x ) -> bool {`
`539`	`539`	`template< typename C, typename X >`
`540`	`540`	`requires (std::is_base_of_v<X, C> && !std::is_same_v<C,X>)`
`541`	`541`	`auto is( X const* x ) -> bool {`
`542`		`- return dynamic_cast<C const&>(x) != nullptr;`
	`542`	`+ return dynamic_cast<C const*>(x) != nullptr;`
`543`	`543`	`}`
`544`	`544`
`545`	`545`	`template< typename C, typename X >`