refactor: share the H1Client Config via an Arc

Author: Fishrock123

src/h1/mod.rs

@@ -5,6 +5,7 @@ use std::convert::{Infallible, TryFrom};
 
 use std::fmt::Debug;
 use std::net::SocketAddr;
+use std::sync::Arc;
 
 use async_h1::client;
 use async_std::net::TcpStream;
@@ -45,7 +46,7 @@ pub struct H1Client {
     #[cfg(any(feature = "native-tls", feature = "rustls"))]
     https_pools: HttpsPool,
     max_concurrent_connections: usize,
-    config: Config,
+    config: Arc<Config>,
 }
 
 impl Debug for H1Client {
@@ -89,7 +90,7 @@ impl Debug for H1Client {
 
         #[cfg(not(feature = "rustls"))]
         {
-            dbg_struct.field("config", &self.config);
+            dbg_struct.field("config", &*self.config);
         }
 
         dbg_struct.finish()
@@ -110,7 +111,7 @@ impl H1Client {
             #[cfg(any(feature = "native-tls", feature = "rustls"))]
             https_pools: DashMap::new(),
             max_concurrent_connections: DEFAULT_MAX_CONCURRENT_CONNECTIONS,
-            config: Config::default(),
+            config: Arc::new(Config::default()),
         }
     }
 
@@ -121,7 +122,7 @@ impl H1Client {
             #[cfg(any(feature = "native-tls", feature = "rustls"))]
             https_pools: DashMap::new(),
             max_concurrent_connections: max,
-            config: Config::default(),
+            config: Arc::new(Config::default()),
         }
     }
 }
@@ -282,15 +283,15 @@ impl HttpClient for H1Client {
     ///
     /// Config options may not impact existing connections.
     fn set_config(&mut self, config: Config) -> http_types::Result<()> {
-        self.config = config;
+        self.config = Arc::new(config);
 
         Ok(())
     }
 
     #[cfg(feature = "unstable-config")]
     /// Get the current configuration.
     fn config(&self) -> &Config {
-        &self.config
+        &*self.config
     }
 }
 
@@ -304,7 +305,7 @@ impl TryFrom<Config> for H1Client {
             #[cfg(any(feature = "native-tls", feature = "rustls"))]
             https_pools: DashMap::new(),
             max_concurrent_connections: DEFAULT_MAX_CONCURRENT_CONNECTIONS,
-            config,
+            config: Arc::new(config),
         })
     }
 }

src/h1/tcp.rs

@@ -1,5 +1,6 @@
 use std::net::SocketAddr;
 use std::pin::Pin;
+use std::sync::Arc;
 
 use async_std::net::TcpStream;
 use async_trait::async_trait;
@@ -13,11 +14,11 @@ use crate::Config;
 #[cfg_attr(not(feature = "rustls"), derive(std::fmt::Debug))]
 pub(crate) struct TcpConnection {
     addr: SocketAddr,
-    config: Config,
+    config: Arc<Config>,
 }
 
 impl TcpConnection {
-    pub(crate) fn new(addr: SocketAddr, config: Config) -> Self {
+    pub(crate) fn new(addr: SocketAddr, config: Arc<Config>) -> Self {
         Self { addr, config }
     }
 }

src/h1/tls.rs

@@ -1,5 +1,6 @@
 use std::net::SocketAddr;
 use std::pin::Pin;
+use std::sync::Arc;
 
 use async_std::net::TcpStream;
 use async_trait::async_trait;
@@ -22,11 +23,11 @@ use crate::{Config, Error};
 pub(crate) struct TlsConnection {
     host: String,
     addr: SocketAddr,
-    config: Config,
+    config: Arc<Config>,
 }
 
 impl TlsConnection {
-    pub(crate) fn new(host: String, addr: SocketAddr, config: Config) -> Self {
+    pub(crate) fn new(host: String, addr: SocketAddr, config: Arc<Config>) -> Self {
         Self { host, addr, config }
     }
 }