Skip to content

CLIP Guided Image2Image #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dblunk88 opened this issue Jan 5, 2023 · 15 comments
Closed

CLIP Guided Image2Image #1929

dblunk88 opened this issue Jan 5, 2023 · 15 comments

Comments

@dblunk88
Copy link
Contributor

dblunk88 commented Jan 5, 2023

The CLIP guided text2img is pretty good. Would be nice to be able to use it for img2img

@patrickvonplaten
Copy link
Contributor

cc @patil-suraj,

Would be great to make this a community pipeline !

@akshay-babbar
Copy link

Hi @patrickvonplaten , since it will be my first issue ever, i will be happy to take this up if someone can guide me.
Can this be assigned to me?

@patrickvonplaten
Copy link
Contributor

Hey @akshay-babbar,

sure would you like to open a PR for it?

@akshay-babbar
Copy link

akshay-babbar commented Jan 13, 2023

Yes @patrickvonplaten i would like to, but from the above , it is not clear to me what needs to be done exactly? Can you explain? Is this a reference point?

@patrickvonplaten
Copy link
Contributor

Hey @akshay-babbar,

The goal here is to make a community pipeline (see: #841)
that does img2img and is guided by CLIP, so quite similar to: https://github.com/huggingface/diffusers/blob/main/examples/community/clip_guided_stable_diffusion.py

@akshay-babbar
Copy link

Sure @patrickvonplaten , will be a good learning for me, can you assign this to me?

@patil-suraj
Copy link
Contributor

Hey @akshay-babbar thanks, just assigned it to you, let me know if you need any help :)

@akshay-babbar
Copy link

Thanks @patil-suraj

@ryx19th
Copy link

ryx19th commented Feb 14, 2023

Hi may I ask if any update here?

@nipunjindal
Copy link
Contributor

nipunjindal commented Mar 14, 2023

Hello @patrickvonplaten,

I'd like to take it up and raise a PR.
Before moving ahead can you clarify my understanding, I'd have to add another pipeline in the community (as suggested in #841) with additional CLIP guidance?
For the Img2Img pipeline, do I inherit from https://github.com/huggingface/diffusers/blob/v0.14.0/src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_img2img.py#L93 or should I duplicate the code and mark duplicate as I read on other threads.

Would love to get clarification to enable faster convergence.

@akshay-babbar
Copy link

Hey @patil-suraj, Sorry but I was/am keeping busy, so could not get back to this. So for now please feel free to assign this issue to someone else.
Thanks.

@nipunjindal
Copy link
Contributor

Hello @patil-suraj @patrickvonplaten,

Here is the PR(#2723) for CLIP guidance for Img2Img pipeline. Let me know your thoughts.

@patrickvonplaten patrickvonplaten added Good second issue and removed good first issue Good for newcomers labels Mar 18, 2023
@nipunjindal
Copy link
Contributor

Hello @patil-suraj @patrickvonplaten,

Sorry for the ping, were you able to take a look at the PR and would you have some initial comments?

@patrickvonplaten
Copy link
Contributor

Merged! Well done, looks great!

@dblunk88
Copy link
Contributor Author

wohoo! Awesome work! Thank you for the awesome feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants