Skip to content

Ghost dependency onnxruntime-common #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks
ae9is opened this issue Dec 10, 2024 · 2 comments · May be fixed by #1088 or #1089
Open
5 tasks

Ghost dependency onnxruntime-common #1087

ae9is opened this issue Dec 10, 2024 · 2 comments · May be fixed by #1088 or #1089
Labels
bug Something isn't working

Comments

@ae9is
Copy link

ae9is commented Dec 10, 2024

System Info

n/a

Environment/Platform

  • Website/web-app
  • Browser extension
  • Server-side (e.g., Node.js, Deno, Bun)
  • Desktop app (e.g., Electron)
  • Other (e.g., VSCode extension)

Description

onnxruntime-common is imported but not declared as a dependency in package.json.

export { Tensor } from 'onnxruntime-common';

Reproduction

npm hides issues with ghost dependencies, use another package manager like pnpm to easily verify.

@Xmader
Copy link

Xmader commented Apr 11, 2025

onnxruntime-common is a dependency for both onnxruntime-node and onnxruntime-web

@ae9is
Copy link
Author

ae9is commented Apr 16, 2025

onnxruntime-common is a dependency for both onnxruntime-node and onnxruntime-web

Not sure what point you're trying to make here, but I just checked and the ghost dependency still isn't fixed in main.

export { Tensor } from 'onnxruntime-common';

"dependencies": {
"@huggingface/jinja": "^0.3.4",
"onnxruntime-node": "1.21.0",
"onnxruntime-web": "1.22.0-dev.20250409-89f8206ba4",
"sharp": "^0.34.1"
},

If anyone needs to build Transformers.js themselves using pnpm feel free to check out the two PRs linked previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants