From 5aa803d39e5416fae0e5965b1594b0886e14b3e5 Mon Sep 17 00:00:00 2001 From: Wing Lian Date: Mon, 1 Dec 2025 22:35:30 -0500 Subject: [PATCH] handle get_input_embeddings() on models like gemma3 gracefully --- src/transformers/modeling_utils.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/transformers/modeling_utils.py b/src/transformers/modeling_utils.py index 64c5893b5172..57c46d05e669 100644 --- a/src/transformers/modeling_utils.py +++ b/src/transformers/modeling_utils.py @@ -1983,7 +1983,11 @@ def make_inputs_require_grads(module, input, output): if not (isinstance(module, PreTrainedModel) and hasattr(module, "get_input_embeddings")): continue - input_embeddings = module.get_input_embeddings() + try: + input_embeddings = module.get_input_embeddings() + except NotImplementedError: + # handle submodules such as siglip which don't have this implemented + input_embeddings = None if input_embeddings is None: continue