From f9b8130efa760b281d7e6e68d857728d19d1f37d Mon Sep 17 00:00:00 2001 From: Cyril Vallez Date: Fri, 30 Jan 2026 12:18:55 +0100 Subject: [PATCH 1/6] switch mapping to test poc --- src/transformers/conversion_mapping.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/transformers/conversion_mapping.py b/src/transformers/conversion_mapping.py index a413692383f7..4281d10f7167 100644 --- a/src/transformers/conversion_mapping.py +++ b/src/transformers/conversion_mapping.py @@ -85,11 +85,11 @@ def _build_checkpoint_conversion_mapping(): ), ], "mixtral": [ - WeightRenaming(".block_sparse_moe.gate", ".mlp.gate"), + WeightRenaming("block_sparse_moe.", "mlp."), WeightConverter( source_patterns=[ - "block_sparse_moe.experts.*.w1.weight", - "block_sparse_moe.experts.*.w3.weight", + "mlp.experts.*.w1.weight", + "mlp.experts.*.w3.weight", ], # you give me a list of 2 keys, I collect a list of a list of tensors target_patterns="mlp.experts.gate_up_proj", # target key gets the list of two tensors operations=[ @@ -101,7 +101,7 @@ def _build_checkpoint_conversion_mapping(): ), WeightConverter( source_patterns=[ - "block_sparse_moe.experts.*.w2.weight", + "mlp.experts.*.w2.weight", ], target_patterns="mlp.experts.down_proj", # target key gets the list of two tensors operations=[ From 802b3c181cfb56f6eb48989a182367faf4d73209 Mon Sep 17 00:00:00 2001 From: Cyril Vallez Date: Fri, 30 Jan 2026 12:36:39 +0100 Subject: [PATCH 2/6] fix --- src/transformers/conversion_mapping.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/transformers/conversion_mapping.py b/src/transformers/conversion_mapping.py index 4281d10f7167..4b0fc03c864c 100644 --- a/src/transformers/conversion_mapping.py +++ b/src/transformers/conversion_mapping.py @@ -85,13 +85,13 @@ def _build_checkpoint_conversion_mapping(): ), ], "mixtral": [ - WeightRenaming("block_sparse_moe.", "mlp."), + WeightRenaming(".block_sparse_moe.", ".mlp."), WeightConverter( source_patterns=[ - "mlp.experts.*.w1.weight", - "mlp.experts.*.w3.weight", + ".experts.*.w1.weight", + ".experts.*.w3.weight", ], # you give me a list of 2 keys, I collect a list of a list of tensors - target_patterns="mlp.experts.gate_up_proj", # target key gets the list of two tensors + target_patterns=".experts.gate_up_proj", # target key gets the list of two tensors operations=[ MergeModulelist( dim=0 @@ -101,9 +101,9 @@ def _build_checkpoint_conversion_mapping(): ), WeightConverter( source_patterns=[ - "mlp.experts.*.w2.weight", + ".experts.*.w2.weight", ], - target_patterns="mlp.experts.down_proj", # target key gets the list of two tensors + target_patterns=".experts.down_proj", # target key gets the list of two tensors operations=[ MergeModulelist( dim=0 From 45aea140db35412281d0df807b6fb11e982903dd Mon Sep 17 00:00:00 2001 From: Cyril Vallez Date: Fri, 30 Jan 2026 12:47:14 +0100 Subject: [PATCH 3/6] more --- src/transformers/conversion_mapping.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/transformers/conversion_mapping.py b/src/transformers/conversion_mapping.py index 4b0fc03c864c..3754128fec63 100644 --- a/src/transformers/conversion_mapping.py +++ b/src/transformers/conversion_mapping.py @@ -142,18 +142,19 @@ def _build_checkpoint_conversion_mapping(): ), ], "phimoe": [ - WeightRenaming(".block_sparse_moe.gate", ".mlp.router"), + WeightRenaming(".block_sparse_moe.", ".mlp."), + WeightRenaming(".gate", ".router"), WeightConverter( source_patterns=[ - "block_sparse_moe.experts.*.w1.weight", - "block_sparse_moe.experts.*.w3.weight", + ".experts.*.w1.weight", + ".experts.*.w3.weight", ], - target_patterns="mlp.experts.gate_up_proj", + target_patterns=".experts.gate_up_proj", operations=[MergeModulelist(dim=0), Concatenate(dim=1)], ), WeightConverter( - source_patterns="block_sparse_moe.experts.*.w2.weight", - target_patterns="mlp.experts.down_proj", + source_patterns=".experts.*.w2.weight", + target_patterns=".experts.down_proj", operations=[MergeModulelist(dim=0)], ), ], From 78f418ee363d2f14f223d2653d355a5d08a0f8cd Mon Sep 17 00:00:00 2001 From: Cyril Vallez Date: Fri, 30 Jan 2026 13:04:31 +0100 Subject: [PATCH 4/6] fix --- src/transformers/conversion_mapping.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/transformers/conversion_mapping.py b/src/transformers/conversion_mapping.py index 3754128fec63..bf33974482df 100644 --- a/src/transformers/conversion_mapping.py +++ b/src/transformers/conversion_mapping.py @@ -143,7 +143,7 @@ def _build_checkpoint_conversion_mapping(): ], "phimoe": [ WeightRenaming(".block_sparse_moe.", ".mlp."), - WeightRenaming(".gate", ".router"), + WeightRenaming(r".gate$", ".router"), WeightConverter( source_patterns=[ ".experts.*.w1.weight", From 210cd93224857f7b2f046cf23d2202824cffef31 Mon Sep 17 00:00:00 2001 From: Cyril Vallez Date: Fri, 30 Jan 2026 13:05:44 +0100 Subject: [PATCH 5/6] comment --- src/transformers/conversion_mapping.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/transformers/conversion_mapping.py b/src/transformers/conversion_mapping.py index bf33974482df..7b0aeadff118 100644 --- a/src/transformers/conversion_mapping.py +++ b/src/transformers/conversion_mapping.py @@ -143,7 +143,7 @@ def _build_checkpoint_conversion_mapping(): ], "phimoe": [ WeightRenaming(".block_sparse_moe.", ".mlp."), - WeightRenaming(r".gate$", ".router"), + WeightRenaming(r".gate$", ".router"), # needs a end of string here, otherwise matches `.gate_up_proj` etc WeightConverter( source_patterns=[ ".experts.*.w1.weight", From 4e3213a1afa29b3369a514a491da70297653124b Mon Sep 17 00:00:00 2001 From: Cyril Vallez Date: Fri, 30 Jan 2026 16:26:23 +0100 Subject: [PATCH 6/6] oupsi --- src/transformers/conversion_mapping.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/transformers/conversion_mapping.py b/src/transformers/conversion_mapping.py index 7b0aeadff118..a277b472adc7 100644 --- a/src/transformers/conversion_mapping.py +++ b/src/transformers/conversion_mapping.py @@ -143,7 +143,7 @@ def _build_checkpoint_conversion_mapping(): ], "phimoe": [ WeightRenaming(".block_sparse_moe.", ".mlp."), - WeightRenaming(r".gate$", ".router"), # needs a end of string here, otherwise matches `.gate_up_proj` etc + WeightRenaming(".gate.weight", ".router.weight"), WeightConverter( source_patterns=[ ".experts.*.w1.weight",