Replace hasOwnProperty check with in operator

Author: Folyd

extension/crate-manager.js

@@ -8,7 +8,7 @@ class CrateDocManager {
     }
 
     static async addCrate(name, version, searchIndex) {
-        if (searchIndex.hasOwnProperty(name)) {
+        if (name in searchIndex) {
             await storage.setItem(`@${name}`, searchIndex);
             let doc = searchIndex[name]["doc"];
             let crates = await CrateDocManager.getCrates();

extension/main.js

@@ -204,11 +204,11 @@ function getPlatformOs() {
             return await crateDocSearcher.search(query);
         },
         onFormat: (index, item) => {
-            if (item.hasOwnProperty("content")) {
+            if ('content' in item) {
                 // 1. Crate list header.
                 // 2. Crate result footer
                 return item;
-            } else if (item.hasOwnProperty("href")) {
+            } else if ('href' in item) {
                 return formatDoc(index, item);
             } else {
                 // Crate name list.

extension/search/book.js

@@ -1,13 +1,13 @@
 class BookSearch {
     constructor(bookIndex) {
         this.pages = {};
-        bookIndex.forEach(({name, url, pages}) => {
+        bookIndex.forEach(({ name, url, pages }) => {
             pages.forEach(([title, path, parentTitles]) => {
                 let cleanedTitle = cleanChapterTitle(title);
-                if (!this.pages.hasOwnProperty(cleanedTitle)) {
+                if (!(cleanedTitle in this.pages)) {
                     this.pages[cleanedTitle] = [];
                 }
-                this.pages[cleanedTitle].push({title, name, url: `${url}${path}.html`, parentTitles});
+                this.pages[cleanedTitle].push({ title, name, url: `${url}${path}.html`, parentTitles });
             });
         });
         this.titles = Object.keys(this.pages);
@@ -20,7 +20,7 @@ class BookSearch {
             if (title.length < query.length) continue;
             let index = title.indexOf(query);
             if (index > -1) {
-                results.push({title, matchIndex: index});
+                results.push({ title, matchIndex: index });
             }
         }
         return results.sort((a, b) => a.title.length - b.title.length)