Skip to content

Commit 9875d49

Browse files
committed
Revert applyDefaults introduced via new-install & new-update
See haskell#4737
1 parent ec418e5 commit 9875d49

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

cabal-install/Distribution/Client/CmdInstall.hs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@ import Distribution.Client.ProjectOrchestration
2121
import Distribution.Client.CmdErrorMessages
2222

2323
import Distribution.Client.Setup
24-
( GlobalFlags, ConfigFlags(..), ConfigExFlags, InstallFlags
25-
, applyFlagDefaults )
24+
( GlobalFlags, ConfigFlags(..), ConfigExFlags, InstallFlags )
2625
import qualified Distribution.Client.Setup as Client
2726
import Distribution.Client.Types
2827
( PackageSpecifier(NamedPackage), UnresolvedSourcePackage )
@@ -119,8 +118,7 @@ installCommand = CommandUI
119118
--
120119
installAction :: (ConfigFlags, ConfigExFlags, InstallFlags, HaddockFlags)
121120
-> [String] -> GlobalFlags -> IO ()
122-
installAction (applyFlagDefaults ->
123-
(configFlags, configExFlags, installFlags, haddockFlags))
121+
installAction (configFlags, configExFlags, installFlags, haddockFlags)
124122
targetStrings globalFlags = do
125123
-- We never try to build tests/benchmarks for remote packages.
126124
-- So we set them as disabled by default and error if they are explicitly

cabal-install/Distribution/Client/CmdUpdate.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import Distribution.Client.JobControl
2121
( newParallelJobControl, spawnJob, collectJob )
2222
import Distribution.Client.Setup
2323
( GlobalFlags, ConfigFlags(..), ConfigExFlags, InstallFlags, UpdateFlags
24-
, applyFlagDefaults, defaultUpdateFlags, RepoContext(..) )
24+
, defaultUpdateFlags, RepoContext(..) )
2525
import Distribution.Simple.Setup
2626
( HaddockFlags, fromFlagOrDefault )
2727
import Distribution.Simple.Utils
@@ -102,7 +102,7 @@ instance Text UpdateRequest where
102102

103103
updateAction :: (ConfigFlags, ConfigExFlags, InstallFlags, HaddockFlags)
104104
-> [String] -> GlobalFlags -> IO ()
105-
updateAction (applyFlagDefaults -> (configFlags, configExFlags, installFlags, haddockFlags))
105+
updateAction (configFlags, configExFlags, installFlags, haddockFlags)
106106
extraArgs globalFlags = do
107107

108108
ProjectBaseContext {

0 commit comments

Comments
 (0)