Does @stamina.retry intentionally not retry exceptions raised from generator functions?

[DoctorJohn]

Just a quick question: Is it intentional that stamina does not retry on exceptions raised from generator functions?

i.e., the following code prints "FUNCTION CALLED" only once:

import stamina


@stamina.retry(on=Exception)
def some_generator_function():
    print("FUNCTION CALLED")
    raise Exception("woops")
    yield 42


list(some_generator_function())

For generator functions, I currently use a custom decorator. If this behaviour is unintentional upstream, I can create a PR adding wrapping support for generator functions.

My custom decorator (type hints stripped for readability)

from functools import wraps
from stamina import retry_context


def stamina_retry_generator(on: type[Exception]):
    def decorator(func):
        @wraps(func)
        def wrapper(*args, **kwargs):
            for attempt in retry_context(on=on):
                with attempt:
                    return (yield from func(*args, **kwargs))

        return wrapper

    return decorator


@stamina_retry_generator(on=Exception)
def some_generator_function():
    print("FUNCTION CALLED")
    raise Exception("woops")
    yield 42


list(some_generator_function())

[hynek]

Definitely not on purpose! Squinting at this: we basically have to add another case on top of sync and async?

[DoctorJohn]

Correct, likely using inspect.isgeneratorfunction and inspect.isasyncgenfunction and wrappers that yield from instead of just returning.

[hynek]

fixed by #123