fix: resource cleanup #454
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mineme0110 <[email protected]>
Signed-off-by: mineme0110 <[email protected]>
Signed-off-by: mineme0110 <[email protected]>
| ZStream.fromQueue(inboundQueue) | ||
| ZStream | ||
| .fromQueue(inboundQueue) | ||
| .timeout(10.seconds) |
There was a problem hiding this comment.
I don't think having a timeout here is good.
Because in the case of web-sockets you may want to keep it open for a longer time.
the .ensuring(inboundQueue.shutdown) LGTM
|
I'm not sure this will make any different for the out of memory problem. I really don't like this whole implementation of DIDCommRoutes. I did this very hachish. |
Signed-off-by: mineme0110 <[email protected]>
amagyar-iohk
requested changes
May 29, 2025
|
@mineme0110 this might be outdated due recent findings. should we close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed and what it is solving
How it was tested
Release Notes / Changelog