Skip to content

Commit bc52712

Browse files
committed
Added empty check for uid
1 parent a4d9a54 commit bc52712

File tree

2 files changed

+26
-15
lines changed

2 files changed

+26
-15
lines changed

Columns/UserId.php

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,16 @@ class UserId extends VisitDimension
4343
* @return mixed|false
4444
*/
4545
public function onNewVisit(Request $request, Visitor $visitor, $action)
46-
{
47-
$username = $visitor->getVisitorColumn('user_id');
48-
$salt = Config::getInstance()->General['salt'];
49-
$usernamehash = substr( sha1( $salt.$username ), 0, 16);
50-
$visitor->setVisitorColumn('user_id', $usernamehash);
51-
52-
return $usernamehash;
46+
{
47+
$uid = $visitor->getVisitorColumn('user_id');
48+
if(!empty($uid))
49+
{
50+
$salt = Config::getInstance()->General['salt'];
51+
$hash = substr(sha1($salt.$uid), 0, 16);
52+
$visitor->setVisitorColumn('user_id', $hash);
53+
return $hash;
54+
}
55+
return $uid;
5356
}
5457

5558
/**
@@ -61,11 +64,14 @@ public function onNewVisit(Request $request, Visitor $visitor, $action)
6164
*/
6265
public function onExistingVisit(Request $request, Visitor $visitor, $action)
6366
{
64-
$username = $visitor->getVisitorColumn('user_id');
65-
$salt = Config::getInstance()->General['salt'];
66-
$usernamehash = substr( sha1( $salt.$username ), 0, 16);
67-
$visitor->setVisitorColumn('user_id', $usernamehash);
68-
69-
return $usernamehash;
67+
$uid = $visitor->getVisitorColumn('user_id');
68+
if(!empty($uid))
69+
{
70+
$salt = Config::getInstance()->General['salt'];
71+
$hash = substr(sha1($salt.$uid), 0, 16);
72+
$visitor->setVisitorColumn('user_id', $hash);
73+
return $hash;
74+
}
75+
return $uid;
7076
}
71-
}
77+
}

plugin.json

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "HashUserId",
33
"description": "Anonymize UserId using salt and sha1 hash.",
4-
"version": "0.1.0",
4+
"version": "0.2.0",
55
"license": "GPL v3+",
66
"theme": false,
77
"homepage": "https://github.com/iMarkus/Piwik-HashUserId",
@@ -14,6 +14,11 @@
1414
"name": "iMarkus",
1515
"email": "[email protected]",
1616
"homepage": "https://github.com/iMarkus"
17+
},
18+
{
19+
"name": "hagor",
20+
"email": "[email protected]",
21+
"homepage": "https://github.com/hagor"
1722
}
1823
],
1924
"support": {

0 commit comments

Comments
 (0)