Bug fix: Right click on the 'New maplayer' dialog would close it (#3247)

mdastous-bentley · web-flow · commit 9bd0f2b71259 · 2022-02-22T15:02:08.000-05:00
* Bug fix: Right click on the new layer dialog would close it.

* changelog
diff --git a/common/changes/@itwin/map-layers/geo-noclose_oncontextmnu_2022-02-21-15-05.json b/common/changes/@itwin/map-layers/geo-noclose_oncontextmnu_2022-02-21-15-05.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@itwin/map-layers",
+      "comment": "Bug fix: Right click on the new map layer dialog would close it.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@itwin/map-layers"
+}
diff --git a/extensions/map-layers/src/ui/widget/AttachLayerPopupButton.tsx b/extensions/map-layers/src/ui/widget/AttachLayerPopupButton.tsx
@@ -435,6 +435,7 @@ export function AttachLayerPopupButton(props: AttachLayerPopupButtonProps) {
         onOutsideClick={handleOutsideClick}
         target={buttonRef.current}
         closeOnEnter={false}
+        closeOnContextMenu={false}
       >
         <div ref={panelRef} className="map-sources-popup-panel" >
           <AttachLayerPanel isOverlay={props.isOverlay} onLayerAttached={handleLayerAttached} />

Original file line number	Diff line number	Diff line change
`@@ -435,6 +435,7 @@ export function AttachLayerPopupButton(props: AttachLayerPopupButtonProps) {`
`435`	`435`	`onOutsideClick={handleOutsideClick}`
`436`	`436`	`target={buttonRef.current}`
`437`	`437`	`closeOnEnter={false}`
	`438`	`+ closeOnContextMenu={false}`
`438`	`439`	`>`
`439`	`440`	`<div ref={panelRef} className="map-sources-popup-panel" >`
`440`	`441`	`<AttachLayerPanel isOverlay={props.isOverlay} onLayerAttached={handleLayerAttached} />`