Skip to content

Commit f044a6c

Browse files
authored
PR #549: Add .NET Standard 2.1 target framework
Also fix the .NET Standard 2.0 target framework moniker: netstandard2.0 instead of netstandard2, see https://docs.microsoft.com/en-us/dotnet/standard/frameworks#supported-target-frameworks
1 parent fec479c commit f044a6c

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

.github/workflows/on-push.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
matrix:
1717
configuration: [debug, release]
1818
os: [ubuntu, windows, macos]
19-
libtarget: [netstandard2]
19+
libtarget: [netstandard2.0, netstandard2.1]
2020
testtarget: [netcoreapp3.1]
2121
include:
2222
- configuration: debug
@@ -31,7 +31,6 @@ jobs:
3131
- uses: actions/checkout@v2
3232

3333
- name: Setup .NET Core
34-
if: matrix.libtarget == 'netstandard2'
3534
uses: actions/setup-dotnet@v1
3635
with:
3736
dotnet-version: '3.1.x'

.github/workflows/pull-request.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
matrix:
1313
configuration: [debug, release]
1414
os: [ubuntu, windows, macos]
15-
target: [netstandard2]
15+
target: [netstandard2.0, netstandard2.1]
1616
include:
1717
- configuration: Debug
1818
os: windows
@@ -24,7 +24,6 @@ jobs:
2424
- uses: actions/checkout@v2
2525

2626
- name: Setup .NET Core
27-
if: matrix.target == 'netstandard2'
2827
uses: actions/setup-dotnet@v1
2928
with:
3029
dotnet-version: '3.1.x'
@@ -78,8 +77,10 @@ jobs:
7877
with:
7978
dotnet-version: '3.1.x'
8079

81-
- name: Build library for .NET Standard 2
82-
run: dotnet build -c Release -f netstandard2 src/ICSharpCode.SharpZipLib/ICSharpCode.SharpZipLib.csproj
80+
- name: Build library for .NET Standard 2.0
81+
run: dotnet build -c Release -f netstandard2.0 src/ICSharpCode.SharpZipLib/ICSharpCode.SharpZipLib.csproj
82+
- name: Build library for .NET Standard 2.1
83+
run: dotnet build -c Release -f netstandard2.1 src/ICSharpCode.SharpZipLib/ICSharpCode.SharpZipLib.csproj
8384
- name: Build library for .NET Framework 4.5
8485
run: dotnet build -c Release -f net45 src/ICSharpCode.SharpZipLib/ICSharpCode.SharpZipLib.csproj
8586

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@ install:
1515
# - nuget restore ICSharpCode.SharpZipLib.sln
1616
# - nuget install NUnit.Console -Version 3.8.0 -OutputDirectory _testRunner
1717
script:
18-
- dotnet build -f netstandard2 src/ICSharpCode.SharpZipLib/ICSharpCode.SharpZipLib.csproj
18+
- dotnet build -f netstandard2.0 src/ICSharpCode.SharpZipLib/ICSharpCode.SharpZipLib.csproj
1919
- dotnet run -c Debug -f netcoreapp2 -p test/ICSharpCode.SharpZipLib.TestBootstrapper/ICSharpCode.SharpZipLib.TestBootstrapper.csproj -- --where "class !~ WindowsNameTransformHandling & test !~ ZipEntryFactoryHandling.CreatedValues & test !~ ZipNameTransformHandling.FilenameCleaning" --result=docs/nunit3-test-results-debug.xml
2020
- dotnet run -c Release -f netcoreapp2 -p test/ICSharpCode.SharpZipLib.TestBootstrapper/ICSharpCode.SharpZipLib.TestBootstrapper.csproj -- --where "class !~ WindowsNameTransformHandling & test !~ ZipEntryFactoryHandling.CreatedValues & test !~ ZipNameTransformHandling.FilenameCleaning" --result=docs\nunit3-test-results-release.xml
2121
# - dotnet test test/ICSharpCode.SharpZipLib.Tests/ICSharpCode.SharpZipLib.Tests.csproj
2222
# - xbuild /p:Configuration=Release ICSharpCode.SharpZipLib.sln
2323
# - mono ./packages/NUnit.ConsoleRunner.3.2.1/tools/nunit3-console.exe --framework=mono-4.0 --labels=All --result=./Documentation/nunit3-test-results-travis.xml ./bin/Release/ICSharpCode.SharpZipLib.Tests.dll
2424
after_script:
25-
- dotnet pack -f netstandard2 -o _dist/ src/ICSharpCode.SharpZipLib/ICSharpCode.SharpZipLib.csproj
25+
- dotnet pack -f netstandard2.0 -o _dist/ src/ICSharpCode.SharpZipLib/ICSharpCode.SharpZipLib.csproj
2626
#cache:
2727
# directories:
2828
# - bin

src/ICSharpCode.SharpZipLib/ICSharpCode.SharpZipLib.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFrameworks>netstandard2;net45</TargetFrameworks>
4+
<TargetFrameworks>netstandard2.0;netstandard2.1;net45</TargetFrameworks>
55
<SignAssembly>True</SignAssembly>
66
<AssemblyOriginatorKeyFile>../../assets/ICSharpCode.SharpZipLib.snk</AssemblyOriginatorKeyFile>
77
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>

0 commit comments

Comments
 (0)