feat(remove): drop items instead of deleting them

Change remove_item and batch_remove_items to mark items as "dropped"
status rather than physically deleting them from OmniFocus. This
preserves data and allows recovery if needed.

Author: igrybkov

src/omnifocus_mcp/mcp_tools/batch/batch_remove.py

@@ -1,4 +1,8 @@
-"""Batch remove items tool for OmniFocus."""
+"""Batch remove items tool for OmniFocus.
+
+Note: This tool drops items (marks them as dropped) instead of physically deleting them.
+This preserves data and allows recovery if needed.
+"""
 
 import json
 from typing import Any
@@ -13,6 +17,9 @@ async def batch_remove_items(
     """
     Remove multiple tasks or projects from OmniFocus in a single operation.
 
+    Note: Items are dropped (marked as dropped status) rather than physically deleted.
+    This preserves data and allows recovery if needed.
+
     Args:
         items: List of items to remove. Each item is a dict with:
             - id: Optional ID of the item (preferred)
@@ -23,7 +30,7 @@ async def batch_remove_items(
         JSON string with results in the following format:
         {
             "total": <number of items attempted>,
-            "success": <number of items removed successfully>,
+            "success": <number of items dropped successfully>,
             "failed": <number of items that failed>,
             "results": [
                 {

src/omnifocus_mcp/mcp_tools/tasks/remove_item.py

@@ -1,4 +1,8 @@
-"""Remove item tool for OmniFocus."""
+"""Remove item tool for OmniFocus.
+
+Note: This tool drops items (marks them as dropped) instead of physically deleting them.
+This preserves data and allows recovery if needed.
+"""
 
 import asyncio
 
@@ -13,6 +17,9 @@ async def remove_item(
     """
     Remove a task or project from OmniFocus.
 
+    Note: Items are dropped (marked as dropped status) rather than physically deleted.
+    This preserves data and allows recovery if needed.
+
     Args:
         name: The name of the task or project to remove (used if id not provided)
         id: The ID of the task or project to remove (preferred)
@@ -31,15 +38,21 @@ async def remove_item(
 
         # Build result message
         if id:
-            result_msg = f"{item_type.capitalize()} removed successfully (by ID)"
+            result_msg = f"{item_type.capitalize()} dropped successfully (by ID)"
+        else:
+            result_msg = f"{item_type.capitalize()} dropped successfully: {name}"
+
+        # Drop items instead of deleting - different syntax for tasks vs projects
+        if item_type == "project":
+            drop_statement = "set status of theItem to dropped status"
         else:
-            result_msg = f"{item_type.capitalize()} removed successfully: {name}"
+            drop_statement = "set dropped of theItem to true"
 
         script = f'''
 tell application "OmniFocus"
     tell default document
         {find_clause}
-        delete theItem
+        {drop_statement}
     end tell
 end tell
 return "{result_msg}"

tests/test_tasks.py

@@ -301,37 +301,42 @@ async def test_edit_task_parent_and_position_change(self):
 
 
 class TestRemoveItem:
-    """Tests for remove_item function."""
+    """Tests for remove_item function (drops items instead of deleting)."""
 
     @pytest.mark.asyncio
     async def test_remove_task(self):
-        """Test removing a task."""
+        """Test removing (dropping) a task."""
         with patch(
             "omnifocus_mcp.mcp_tools.tasks.remove_item.asyncio.create_subprocess_exec"
         ) as mock_exec:
             # Setup mock
             mock_process = AsyncMock()
-            mock_process.communicate.return_value = (b"Task removed successfully: Test Task", b"")
+            mock_process.communicate.return_value = (b"Task dropped successfully: Test Task", b"")
             mock_process.returncode = 0
             mock_exec.return_value = mock_process
 
             # Execute
             result = await remove_item(name="Test Task")
 
             # Verify
-            assert "Task removed successfully" in result
+            assert "Task dropped successfully" in result
             mock_exec.assert_called_once()
+            # Verify the script uses 'set dropped' instead of 'delete'
+            call_args = mock_exec.call_args
+            script = call_args[0][2]
+            assert "set dropped of theItem to true" in script
+            assert "delete" not in script
 
     @pytest.mark.asyncio
     async def test_remove_project(self):
-        """Test removing a project."""
+        """Test removing (dropping) a project."""
         with patch(
             "omnifocus_mcp.mcp_tools.tasks.remove_item.asyncio.create_subprocess_exec"
         ) as mock_exec:
             # Setup mock
             mock_process = AsyncMock()
             mock_process.communicate.return_value = (
-                b"Project removed successfully: Test Project",
+                b"Project dropped successfully: Test Project",
                 b"",
             )
             mock_process.returncode = 0
@@ -341,8 +346,13 @@ async def test_remove_project(self):
             result = await remove_item(name="Test Project", item_type="project")
 
             # Verify
-            assert "Project removed successfully" in result
+            assert "Project dropped successfully" in result
             mock_exec.assert_called_once()
+            # Verify the script uses 'dropped status' instead of 'delete'
+            call_args = mock_exec.call_args
+            script = call_args[0][2]
+            assert "set status of theItem to dropped status" in script
+            assert "delete" not in script
 
     @pytest.mark.asyncio
     async def test_remove_item_escapes_special_characters(self):
@@ -352,15 +362,15 @@ async def test_remove_item_escapes_special_characters(self):
         ) as mock_exec:
             # Setup mock
             mock_process = AsyncMock()
-            mock_process.communicate.return_value = (b"Task removed successfully", b"")
+            mock_process.communicate.return_value = (b"Task dropped successfully", b"")
             mock_process.returncode = 0
             mock_exec.return_value = mock_process
 
             # Execute with special characters
             result = await remove_item(name='Task "with" quotes')
 
             # Verify
-            assert "Task removed successfully" in result
+            assert "Task dropped successfully" in result
             # Check that osascript was called with escaped string
             call_args = mock_exec.call_args
             script = call_args[0][2]