Skip to content

Feature Request: IndexSet entry APIs #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zao111222333 opened this issue Apr 8, 2025 · 1 comment
Open

Feature Request: IndexSet entry APIs #388

zao111222333 opened this issue Apr 8, 2025 · 1 comment
Labels
waiting-for-std Changes waiting for stabilization in the standard library, so we can match the API.

Comments

@zao111222333
Copy link

zao111222333 commented Apr 8, 2025

I wonder whether IndexSet::entry is in the roadmap, if yes, I can try to submit PR.
Like the one in hashbrown::HashSet, for IndexSet it will be

impl<T, S> IndexSet<T, S>
where
    T: Hash + Eq,
    S: BuildHasher,
{
    pub fn entry(&mut self, value: T) -> Entry<'_, T, S> { ... }
}
pub enum Entry<'a,T,S> { ... }
@cuviper cuviper added the waiting-for-std Changes waiting for stabilization in the standard library, so we can match the API. label Apr 8, 2025
@cuviper
Copy link
Member

cuviper commented Apr 8, 2025

Yes, but I'll want to match the eventual API of the standard library HashSet, rust-lang/rust#60896. I don't mind having a draft PR waiting for that, if you're so inclined, but it could be a while before that will be merged.

@zao111222333 zao111222333 changed the title Support IndexSet::entry Feature Request: IndexSet entry APIs Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-std Changes waiting for stabilization in the standard library, so we can match the API.
Projects
None yet
Development

No branches or pull requests

2 participants