chore: fix staticcheck and syntax errors

Author: Jacob Marble

bolt/kv.go

@@ -123,7 +123,7 @@ func (s *KVStore) Update(ctx context.Context, fn func(tx kv.Tx) error) error {
 
 // Backup copies all K:Vs to a writer, in BoltDB format.
 func (s *KVStore) Backup(ctx context.Context, w io.Writer) error {
-	span, ctx := tracing.StartSpanFromContext(ctx)
+	span, _ := tracing.StartSpanFromContext(ctx)
 	defer span.Finish()
 
 	return s.db.View(func(tx *bolt.Tx) error {

http/backup_service.go

@@ -199,6 +199,7 @@ func (s *BackupService) FetchBackupFile(ctx context.Context, backupID int, backu
 		return err
 	}
 	SetToken(s.Token, req)
+	req = req.WithContext(ctx)
 
 	hc := NewClient(u.Scheme, s.InsecureSkipVerify)
 	hc.Timeout = httpClientTimeout

storage/engine.go

@@ -705,7 +705,7 @@ func (e *Engine) CreateBackup(ctx context.Context) (int, []string, error) {
 // FetchBackupFile writes a given backup file to the provided writer.
 // After a successful write, the internal copy is removed.
 func (e *Engine) FetchBackupFile(ctx context.Context, backupID int, backupFile string, w io.Writer) error {
-	span, ctx := tracing.StartSpanFromContext(ctx)
+	span, _ := tracing.StartSpanFromContext(ctx)
 	defer span.Finish()
 
 	e.mu.RLock()

tsdb/tsm1/file_store.go

@@ -1235,7 +1235,7 @@ func (f *FileStore) CreateSnapshot(ctx context.Context) (backupID int, backupDir
 
 	// create the tmp directory and add the hard links. there is no longer any shared
 	// mutable state.
-	err := os.Mkdir(backupDirFullPath, 0777)
+	err = os.Mkdir(backupDirFullPath, 0777)
 	if err != nil {
 		return 0, "", err
 	}