From 0b9169e01467d1e943ec60d7d91673e5c8870306 Mon Sep 17 00:00:00 2001 From: Nathan Shaaban Date: Mon, 4 Oct 2021 08:37:22 -0700 Subject: [PATCH 1/3] update PR template to import surf or reqwest --- .github/PULL_REQUEST_TEMPLATE.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index dc7ee78..d4034c6 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -4,7 +4,9 @@ ### Checklist - [ ] Formatted code using `cargo fmt --all` -- [ ] Linted code using clippy `cargo clippy --all-targets --all-features -- -D warnings` +- [ ] Linted code using clippy + - [ ] surf based features `cd influxdb;cargo clippy --all-targets --no-default-features --features derive,use-serde,curl-client,h1-client,h1-client-rustls,hyper-client,wasm-client -- -D warnings;cd ..` + - [ ] reqwest based features `cargo clippy --all-targets --features derive,use-serde,reqwest-client,reqwest-client-rustls -- -D warnings` - [ ] Updated README.md using `cargo readme -r influxdb -t ../README.tpl > README.md` - [ ] Reviewed the diff. Did you leave any print statements or unnecessary comments? -- [ ] Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment \ No newline at end of file +- [ ] Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment From 7084a9dd69059558a02d6fbed66ad1e8f2827e80 Mon Sep 17 00:00:00 2001 From: Nathan Shaaban Date: Mon, 4 Oct 2021 10:59:54 -0700 Subject: [PATCH 2/3] docs: shorter commands --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index d4034c6..6040c28 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -5,8 +5,8 @@ ### Checklist - [ ] Formatted code using `cargo fmt --all` - [ ] Linted code using clippy - - [ ] surf based features `cd influxdb;cargo clippy --all-targets --no-default-features --features derive,use-serde,curl-client,h1-client,h1-client-rustls,hyper-client,wasm-client -- -D warnings;cd ..` - - [ ] reqwest based features `cargo clippy --all-targets --features derive,use-serde,reqwest-client,reqwest-client-rustls -- -D warnings` + - [ ] surf based features `cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features use-serde,derive,hyper-client -- -D warnings` + - [ ] reqwest based features `cargo clippy --all-targets --no-default-features --features use-serde,derive,reqwest-client -- -D warnings` - [ ] Updated README.md using `cargo readme -r influxdb -t ../README.tpl > README.md` - [ ] Reviewed the diff. Did you leave any print statements or unnecessary comments? - [ ] Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment From 5f3bfffbc7bbb99a6345c05fef223decd2590f21 Mon Sep 17 00:00:00 2001 From: Dominic Date: Mon, 4 Oct 2021 20:05:49 +0200 Subject: [PATCH 3/3] use clippy commands from CI --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 6040c28..676feeb 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -5,8 +5,8 @@ ### Checklist - [ ] Formatted code using `cargo fmt --all` - [ ] Linted code using clippy - - [ ] surf based features `cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features use-serde,derive,hyper-client -- -D warnings` - - [ ] reqwest based features `cargo clippy --all-targets --no-default-features --features use-serde,derive,reqwest-client -- -D warnings` + - [ ] with reqwest feature: `cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features use-serde,derive,reqwest-client -- -D warnings` + - [ ] with surf feature: `cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features use-serde,derive,hyper-client -- -D warnings` - [ ] Updated README.md using `cargo readme -r influxdb -t ../README.tpl > README.md` - [ ] Reviewed the diff. Did you leave any print statements or unnecessary comments? - [ ] Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment